From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ACB121ABA5 for ; Sat, 28 Jun 2025 23:30:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751153434; cv=none; b=qG6QLoudkYfjcjHW1rByOvLtpjX//6/i/mWBimsIUPmdTblzz55G8mwDw4UCWTAJrtQKMFxJTzyO64E/QdZMoXWC0fsSpqJo7I5qxJ31X9rvbihoY7RwoiF+yXkEvA3wqa2ge4xkNgq2ArMK8q8vWb+QmvxMEz1Oag/KmN8T/KY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751153434; c=relaxed/simple; bh=0L3TcnOnAT37xurn4zHF7Uelnh1A1OIPxvlh7Hv5QGQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eg0WNXg+Fu/FipeXk5GvknYsQGRJtrvVihMVVtQFfeVJoxcSOUaIGNAyJ9drXu4CFrfcUFbKsEjrP9P1qPF1BZHzB5vftCFy8K+ad1fF38gasE4/9Ba8pka/U222l6E4GdKF74tr+HPsGA8L6snHJU6enhydTkewQ/+akHFE4ok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=eJMIj9kG; arc=none smtp.client-ip=209.85.160.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="eJMIj9kG" Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-2ef8df09ce9so328615fac.1 for ; Sat, 28 Jun 2025 16:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1751153431; x=1751758231; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3LV2whTVcFBv8HGVSk50MOoWwYm/BUMUzIcy7LK/5Gk=; b=eJMIj9kGY+TCzlzUxoZ9vT58J5vLtzhtCwnoVWwn+6IKmnb/QVg08tLzfh9y/rp1/2 Kwivh55qtslzt3hnv2QKN7Dx66w89ZV9FKjMQ3EFL0IpVAAzL3qht7hSpuuPZRh7hWco BwUwulm/iZijHB61og4RFmUxP0M3SmJ3OFy24UM2LZS/fLXh3s/JAoojTAoGXZf3SC/X YdfzUdEZa+Nb5bnKW/Ea4NdtjufBok7ESgfYpYel/CNQBDxh0yxKchin48Dk8YWQslTc mROnDP+8iCOBggSrRghyoTr/eSAKebCBLExQWrZCB7VatLAUm8YP8I4aq4k0ckiAsneS iXqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751153431; x=1751758231; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3LV2whTVcFBv8HGVSk50MOoWwYm/BUMUzIcy7LK/5Gk=; b=Yr6GKmBfmnfJdjJWqdSgu4eVDevIpBa2ZjkGivGaXJd7ZWKzvNLLvYSnDg1k205qe9 EPdoxt2iB8dj9ye2aVeUPjOHoiCLiUKMKwwyGUtFFyWl6lkfQ0ZJa9LBYMTpS0SizvVn rT36MBtKzaL8DIQF/dCB4IwbwKsqScNYMHt0/HLgM19LGaEcNwH09MGFuMLtATWCDys7 gVMuXkeh+1rwKzvZj/UviGboNp3K3rF97TheQjOzCpdoMgZqKZng/tX3TS1o967VTklk ZHUhgy3xnzhJpNV1tfnrgOlHfe+Atmq83/BhZyhVjIyZ/SWGgfGOv8q/L4uxMQPkvV6a yXMg== X-Forwarded-Encrypted: i=1; AJvYcCX1Yk4VxXPsk6srjrGJxCd9ahs4p2fZZ1y8Z+7SYHOn+rmsGp1qqR7GXOLKjyG51jQl/qCbVRJJVns=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5yWVYknZE2+l0LWW6rUY6RiFUUqa1D9qRAz1f9nFVX4IoG0rQ Ootzv6gns6zKXbNO+nuo7y9vF6dL8B3a/EePop2G5L3EmZszt7sPUuOgL1w8F2Z3JOg= X-Gm-Gg: ASbGncvNXni/0iHll6Rrcszd5tMi/3a3R7T2WuNTRN3udelAx2kK4dPLRmYSUss7vcf 8TPj7MSQ/itivYXYF9YxvOltVJqnSBOvLxc9etMr6hdSCkVqHFE1ck/v8ts/GKqbs/aYyePG4Hl fJlUm7TfgwWsMXhAcy7kf6D2pGjjyZMwkNN/NM0ZGa4AiExySljp31z94Y98b/gnTmaLqsYE3G5 etBU/Q23ANSKjWWvSgaJiu7eK4R4Red/lV7+DvzTqutlWbEWiuW+yMUJD0qdU0DgLEL6PvfQ+56 a1XC0gbyENzIUcj+ylyfWvzJbWKQZtP/najG/P+Ca5ul8RwE4O5aVJGmSKY5vuAWeiYMpZAAhmH dAjEZspcxGC1NTmXhQcPHzsygnceu2zjhI3HNXgE= X-Google-Smtp-Source: AGHT+IFPRb5c72fGGjzcl2TWNpxe5UqjFvHdpbDERh59UE43Z4EhY5vjoD630Wsnz6iYSlvBePYWyg== X-Received: by 2002:a05:6870:cd89:b0:2ea:7101:7dc1 with SMTP id 586e51a60fabf-2efed73119bmr5062597fac.33.1751153431549; Sat, 28 Jun 2025 16:30:31 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:3092:a48c:b0c6:cbf4? ([2600:8803:e7e4:1d00:3092:a48c:b0c6:cbf4]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2efd50fa38asm1750229fac.40.2025.06.28.16.30.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Jun 2025 16:30:30 -0700 (PDT) Message-ID: Date: Sat, 28 Jun 2025 18:30:28 -0500 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/5] iio: adc: ti-adc128s052: Add lower resolution devices support To: Sukrut Bellary , Andy Shevchenko Cc: Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matti Vaittinen , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Angelo Compagnucci , Nishanth Menon , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250614091504.575685-1-sbellary@baylibre.com> <20250614091504.575685-5-sbellary@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/28/25 6:09 PM, Sukrut Bellary wrote: > On Sat, Jun 14, 2025 at 09:45:43PM +0300, Andy Shevchenko wrote: >> On Sat, Jun 14, 2025 at 12:15 PM Sukrut Bellary wrote: >>> >>> The adcxx communicates with a host processor via an SPI/Microwire Bus >>> interface. The device family responds with 12-bit data, of which the LSB bits >>> are transmitted by the lower resolution devices as 0. >>> The unavailable bits are 0 in LSB. >>> Shift is calculated per resolution and used in scaling and raw data read. >>> >>> Lets reuse the driver to support the family of devices with name >>> ADCS, where >> >> I believe it's incorrect, i.e. it's something like ...S, where >> is something you need to clarify, and is definitely a speed >> in kSPS. >> > Thank you for the review. > I am not sure about the last s in . > It could be TI's silicon spins versioning. > I couldn't find any information about it in any of the datasheets. > I can drop the last s or mark it as and specify the first two as > maximum speed. > I have a hunch that the last digit has to do with pinout/number of power supplies. adc128s052 has two supplies V_A and V_D while the others only have V_A. If this sounds vaguely familiar, it is because it was discussed today in this thread [1] that Jonathan CC'ed you in. :-) [1]: https://lore.kernel.org/linux-iio/20250628162910.1256b220@jic23-huawei/