linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: William Breathitt Gray <vilhelm.gray@gmail.com>,
	Lars-Peter Clausen <lars@metafoo.de>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Matt Ranostay <matt.ranostay@konsulko.com>,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/8] iio: stx104: Set parent device
Date: Sun, 19 Feb 2017 11:55:58 +0000	[thread overview]
Message-ID: <bde4803e-fdcf-e29d-4c33-db539217d0c4@kernel.org> (raw)
In-Reply-To: <20170211125833.GA31343@sophia>

On 11/02/17 12:58, William Breathitt Gray wrote:
> On Sat, Feb 11, 2017 at 01:34:14PM +0100, Lars-Peter Clausen wrote:
>> Initialize the parent of the IIO device to the device that registered it.
>> This makes sure that the IIO device appears the right level in the device
>> hierarchy.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Hmm. Took me a few moments to decide whether to push these as fixes or
not.  In the end I concluded that they have always been broken, so whilst
they are clearly a fix we want in, the probably don't need to be rushed
in or applied to old kernels. For drivers that were in this cycle, I
may push them out as straight forward fixes however.

If anyone disagrees then shout quickly!

Applied to the togreg branch of iio.git and pushed out as testing.
>> ---
>> drivers/iio/adc/stx104.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/iio/adc/stx104.c b/drivers/iio/adc/stx104.c
>> index be2de48..2df84fa5 100644
>> --- a/drivers/iio/adc/stx104.c
>> +++ b/drivers/iio/adc/stx104.c
>> @@ -318,6 +318,7 @@ static int stx104_probe(struct device *dev, unsigned int id)
>> 	}
>>
>> 	indio_dev->name = dev_name(dev);
>> +	indio_dev->dev.parent = dev;
>>
>> 	priv = iio_priv(indio_dev);
>> 	priv->base = base[id];
>> -- 
>> 2.1.4
>>
> 
> Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com
> 


  reply	other threads:[~2017-02-19 11:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-11 12:34 [PATCH 0/8] iio: Fix missing parent device initalization Lars-Peter Clausen
2017-02-11 12:34 ` [PATCH 1/8] iio: stx104: Set parent device Lars-Peter Clausen
2017-02-11 12:58   ` William Breathitt Gray
2017-02-19 11:55     ` Jonathan Cameron [this message]
2017-02-11 12:34 ` [PATCH 2/8] iio: quad-8: " Lars-Peter Clausen
2017-02-11 12:59   ` William Breathitt Gray
2017-02-11 12:34 ` [PATCH 3/8] iio: cio-dac: " Lars-Peter Clausen
2017-02-11 12:59   ` William Breathitt Gray
2017-02-19 11:58     ` Jonathan Cameron
2017-02-11 12:34 ` [PATCH 4/8] iio: max30100: " Lars-Peter Clausen
2017-02-19 12:00   ` Jonathan Cameron
2017-02-11 12:34 ` [PATCH 5/8] iio: max30102: " Lars-Peter Clausen
2017-02-19 12:01   ` Jonathan Cameron
2017-02-11 12:34 ` [PATCH 6/8] iio: lmp91000: " Lars-Peter Clausen
2017-02-14 15:39   ` Matt Ranostay
2017-02-19 12:02     ` Jonathan Cameron
2017-02-11 12:34 ` [PATCH 7/8] iio: pulsedlight-lidar-lite-v2: " Lars-Peter Clausen
2017-02-14 15:40   ` Matt Ranostay
2017-02-19 12:02     ` Jonathan Cameron
2017-02-11 12:34 ` [PATCH 8/8] iio: maxim_thermocouple: " Lars-Peter Clausen
2017-02-19 12:04   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bde4803e-fdcf-e29d-4c33-db539217d0c4@kernel.org \
    --to=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=matt.ranostay@konsulko.com \
    --cc=pmeerw@pmeerw.net \
    --cc=vilhelm.gray@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).