From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 08/11] dt-bindings: iio: adc: ad7476: Drop redundant prop: true
Date: Mon, 11 Aug 2025 11:51:50 +0300 [thread overview]
Message-ID: <bee66444bf628ba9a34a02738a1842e2abc14290.1754901948.git.mazziesaccount@gmail.com> (raw)
In-Reply-To: <cover.1754901948.git.mazziesaccount@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2739 bytes --]
The ad7476 supports a few variants with different power-supplies and
control GPIOs. The binding first unconditionally introduces all the
properties, and later sets them 'true' or 'false' based on the
combatible.
The 'true' seems to be implied by the initial property introduction so
the 'true' -branches in later conditional handling (based on the
compatible) can be omitted.
Drop the redundant true -branches.
Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
---
Revision history:
v3 => v4:
- New patch
---
.../bindings/iio/adc/adi,ad7476.yaml | 54 +++++++++----------
1 file changed, 24 insertions(+), 30 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7476.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7476.yaml
index d0cb32f136e5..db2a9662bd94 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7476.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7476.yaml
@@ -106,19 +106,17 @@ allOf:
- vcc-supply
# Devices with a vref
- if:
- properties:
- compatible:
- contains:
- enum:
- - adi,ad7091r
- - adi,ad7273
- - adi,ad7274
- - adi,ad7475
- - lltc,ltc2314-14
+ not:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - adi,ad7091r
+ - adi,ad7273
+ - adi,ad7274
+ - adi,ad7475
+ - lltc,ltc2314-14
then:
- properties:
- vref-supply: true
- else:
properties:
vref-supply: false
# Devices with a vref where it is not optional
@@ -135,29 +133,25 @@ allOf:
required:
- vref-supply
- if:
- properties:
- compatible:
- contains:
- enum:
- - adi,ad7475
- - adi,ad7495
+ not:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - adi,ad7475
+ - adi,ad7495
then:
- properties:
- vdrive-supply: true
- else:
properties:
vdrive-supply: false
- if:
- properties:
- compatible:
- contains:
- enum:
- - adi,ad7091
- - adi,ad7091r
+ not:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - adi,ad7091
+ - adi,ad7091r
then:
- properties:
- adi,conversion-start-gpios: true
- else:
properties:
adi,conversion-start-gpios: false
--
2.50.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-08-11 8:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 8:50 [PATCH v4 00/11] Support ROHM BD79105 ADC Matti Vaittinen
2025-08-11 8:50 ` [PATCH v4 01/11] iio: adc: ad7476: Simplify chip type detection Matti Vaittinen
2025-08-11 8:50 ` [PATCH v4 02/11] iio: adc: ad7476: Simplify scale handling Matti Vaittinen
2025-08-11 8:50 ` [PATCH v4 03/11] iio: adc: ad7476: Use mV for internal reference Matti Vaittinen
2025-08-11 8:51 ` [PATCH v4 04/11] iio: adc: ad7476: Use correct channel for bit info Matti Vaittinen
2025-08-11 8:51 ` [PATCH v4 05/11] iio: adc: ad7476: use *_cansleep GPIO APIs Matti Vaittinen
2025-08-11 8:51 ` [PATCH v4 06/11] iio: adc: ad7476: Drop convstart chan_spec Matti Vaittinen
2025-08-11 8:51 ` [PATCH v4 07/11] iio: adc: ad7476: Conditionally call convstart Matti Vaittinen
2025-08-11 8:51 ` Matti Vaittinen [this message]
2025-08-14 7:25 ` [PATCH v4 08/11] dt-bindings: iio: adc: ad7476: Drop redundant prop: true Krzysztof Kozlowski
2025-08-11 8:52 ` [PATCH v4 09/11] dt-bindings: iio: adc: ad7476: Add ROHM bd79105 Matti Vaittinen
2025-08-14 7:29 ` Krzysztof Kozlowski
2025-08-11 8:52 ` [PATCH v4 10/11] iio: adc: ad7476: Support ROHM BD79105 Matti Vaittinen
2025-08-11 8:52 ` [PATCH v4 11/11] MAINTAINERS: A driver for simple 1-channel SPI ADCs Matti Vaittinen
2025-08-16 12:22 ` [PATCH v4 00/11] Support ROHM BD79105 ADC Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bee66444bf628ba9a34a02738a1842e2abc14290.1754901948.git.mazziesaccount@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).