From: Emil Gedenryd <Emil.Gedenryd@axis.com>
To: "jic23@kernel.org" <jic23@kernel.org>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dannenberg@ti.com" <dannenberg@ti.com>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
Kernel <Kernel@axis.com>
Subject: Re: [PATCH v3 1/3] iio: light: opt3001: add missing full-scale range value
Date: Mon, 30 Sep 2024 07:54:46 +0000 [thread overview]
Message-ID: <bf39ddb73f2c0f823f9712a38614964e9b308822.camel@axis.com> (raw)
In-Reply-To: <20240928165737.6ed1e4ff@jic23-huawei>
On Sat, 2024-09-28 at 16:57 +0100, Jonathan Cameron wrote:
> On Mon, 16 Sep 2024 16:56:37 +0200
> Emil Gedenryd <emil.gedenryd@axis.com> wrote:
>
> > The opt3001 driver uses predetermined full-scale range values to
> > determine what exponent to use for event trigger threshold values.
> > The problem is that one of the values specified in the datasheet is
> > missing from the implementation. This causes larger values to be
> > scaled down to an incorrect exponent, effectively reducing the
> > maximum settable threshold value by a factor of 2.
> >
> > Add missing full-scale range array value.
> >
> > Fixes: 94a9b7b1809f ("iio: light: add support for TI's opt3001 light sensor")
> > Signed-off-by: Emil Gedenryd <emil.gedenryd@axis.com>
> This one is already queued up, so you can drop it from future
> versions of this series posted for review.
>
> Thanks,
>
> Jonathan
Okay, I'll leave it out in the future.
Thanks,
Emil
next prev parent reply other threads:[~2024-09-30 7:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 14:56 [PATCH v3 0/3] iio: light: opt3001: add support for TI's opt3002 light sensor Emil Gedenryd
2024-09-16 14:56 ` [PATCH v3 1/3] iio: light: opt3001: add missing full-scale range value Emil Gedenryd
2024-09-28 15:57 ` Jonathan Cameron
2024-09-30 7:54 ` Emil Gedenryd [this message]
2024-09-16 14:56 ` [PATCH v3 2/3] dt-bindings: iio: light: opt3001: add compatible for opt3002 Emil Gedenryd
2024-09-16 15:24 ` Conor Dooley
2024-09-17 7:06 ` Emil Gedenryd
2024-09-16 14:56 ` [PATCH v3 3/3] iio: light: opt3001: add support for TI's opt3002 light sensor Emil Gedenryd
2024-09-28 16:05 ` Jonathan Cameron
2024-09-30 7:53 ` Emil Gedenryd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf39ddb73f2c0f823f9712a38614964e9b308822.camel@axis.com \
--to=emil.gedenryd@axis.com \
--cc=Kernel@axis.com \
--cc=conor+dt@kernel.org \
--cc=dannenberg@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox