From: Jackie Liu <liu.yun@linux.dev>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Jonathan Cameron <jic23@kernel.org>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: adc: da9150-gpadc: fix build on mips CONFIG_MIKROTIK_RB532=y
Date: Mon, 28 Mar 2022 09:08:29 +0800 [thread overview]
Message-ID: <c0b7514d-fa3f-b747-948a-5108ce1a33a6@linux.dev> (raw)
In-Reply-To: <CAHp75VcQ5c1XviKBMr7eU-fsy5jLViVcEt=ahHoSHzqoz3JNpg@mail.gmail.com>
Hi Andy and Jonathan.
Hello, thank you for your replies, in fact, I also think it is not
suitable to do a workaround here, I want to directly try to modify the
definition under the MIPS/rb532 architecture, if possible.
--
Jackie Liu
在 2022/3/28 上午3:35, Andy Shevchenko 写道:
> On Sun, Mar 27, 2022 at 5:49 PM Jonathan Cameron <jic23@kernel.org> wrote:
>> On Thu, 24 Mar 2022 12:18:14 +0200
>> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>>> On Thu, Mar 24, 2022 at 7:58 AM Jackie Liu <liu.yun@linux.dev> wrote:
>
>> From some very basic grepping I 'suspect' you could just push the defines
>> down into arch/mips/rb532/gpio.c but I may well be wrong...
>
> It would be ideal if we may hide them in the C-file(s).
>
prev parent reply other threads:[~2022-03-28 1:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 5:58 [PATCH] iio: adc: da9150-gpadc: fix build on mips CONFIG_MIKROTIK_RB532=y Jackie Liu
2022-03-24 10:18 ` Andy Shevchenko
2022-03-27 14:57 ` Jonathan Cameron
2022-03-27 19:35 ` Andy Shevchenko
2022-03-28 1:08 ` Jackie Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0b7514d-fa3f-b747-948a-5108ce1a33a6@linux.dev \
--to=liu.yun@linux.dev \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox