From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: Hans de Goede <hdegoede@redhat.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: iio/accel/stk8312: Improve unlocking of a mutex in two functions
Date: Fri, 27 Oct 2017 12:15:54 +0200 [thread overview]
Message-ID: <c2620449-b80a-f0ef-c0d2-92d0c7fb4906@users.sourceforge.net> (raw)
In-Reply-To: <20171026170913.5ff10718@archlinux>
> In the second case, the jump backwards just makes the code harder
> to read than it currently is.
Maybe …
But I proposed an other source code layout for useful reasons.
> There is no firm rule about error handling in one place.
There are some design options available.
> If it leads to more complex flow as here, don't do it.
I would appreciate to clarify such a view a bit more.
How would you like to achieve a complete and efficient
exception handling in shown places?
Regards,
Markus
next prev parent reply other threads:[~2017-10-27 10:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 18:55 [PATCH] iio/accel/stk8312: Improve unlocking of a mutex in two functions SF Markus Elfring
2017-10-26 16:09 ` Jonathan Cameron
2017-10-27 10:15 ` SF Markus Elfring [this message]
2017-10-27 11:15 ` Peter Meerwald-Stadler
2017-10-27 12:37 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2620449-b80a-f0ef-c0d2-92d0c7fb4906@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=hdegoede@redhat.com \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).