From: "Nuno Sá" <noname.nuno@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Subject: Re: [PATCH v1 1/1] iio: core: Simplify IIO core managed APIs
Date: Tue, 17 Feb 2026 13:29:07 +0000 [thread overview]
Message-ID: <c27fd07403ed790902bc9ef5a863beeb7b7429be.camel@gmail.com> (raw)
In-Reply-To: <aZQcpJV2GQ8vWnA_@smile.fi.intel.com>
On Tue, 2026-02-17 at 09:45 +0200, Andy Shevchenko wrote:
> On Mon, Feb 16, 2026 at 02:31:57PM +0000, Nuno Sá wrote:
> > On Mon, 2026-02-16 at 09:14 +0100, Andy Shevchenko wrote:
> > > Use devm_add_action_or_reset() instead of devres_alloc() and
> > > devres_add(), which works the same. This will simplify the
> > > code. There is no functional changes.
>
> > LGTM. Just one minor "complain". Anyways:
>
> My answer below.
>
> > Reviewed-by: Nuno Sá <nuno.sa@analog.com>
>
> Thanks!
>
> ...
>
> > > - if (!buffer)
> > > - return -ENOMEM;
> > > + if (IS_ERR(buffer))
> > > + return PTR_ERR(buffer);
> >
> > Subtle change that could have been mentioned in the commit message.
>
> Actually not really a change. Currently the error code is shadowed to -ENOMEM,
Well before that was explicit. Now it also depends on the internals of __devm_add_action().
That is why I said it was subtle. But yes, no functional change.
- Nuno Sá
>
next prev parent reply other threads:[~2026-02-17 13:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 8:14 [PATCH v1 1/1] iio: core: Simplify IIO core managed APIs Andy Shevchenko
2026-02-16 14:31 ` Nuno Sá
2026-02-17 7:45 ` Andy Shevchenko
2026-02-17 13:29 ` Nuno Sá [this message]
2026-02-17 13:32 ` Andy Shevchenko
2026-02-20 10:09 ` Nuno Sá
2026-02-20 10:18 ` Jonathan Cameron
2026-02-20 10:27 ` Andy Shevchenko
2026-02-20 12:14 ` Jonathan Cameron
2026-02-20 13:29 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c27fd07403ed790902bc9ef5a863beeb7b7429be.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox