From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BECB2248B4; Wed, 26 Feb 2025 20:44:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740602654; cv=none; b=MmveOZ0RuDgArrUGisNJBKDU5aOsO9DlpzpHduY+vFx54q9qobAfl5itEtf4LJQwn2haJexu5uT9oxePCH2I+IyxQ9lC8m29vxf1lg31IMEADkw/dM8pGj5jImMFxlG1YYMRn8BPCZeuslapD/Bmg9Tl3Rnd/dTLbPUwAsIqOyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740602654; c=relaxed/simple; bh=oBZ0KKT3UUusD2Td66n5qHAldXEO/TqJIfPFxFe0Ltw=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=IsH1Fxy8hpVtBK150j8tMBjefw2GtpbAGLfYZxTPKwuagzwogZd44SgFTe48SBco9RugZBd14pFJvshd6Em9SjnXEc33xJC3NAmGpmlomWwzaT7uFG9wTRlHsYRZmdHGY1t/3o5sddoPSBKaqEWIW6CIsUqpYbBErOQ/5krpVIE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=T5jWUNLP; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="T5jWUNLP" Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51QJm0Bh012384; Wed, 26 Feb 2025 21:43:59 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= dV2n3+CLnbeCuZtQ8iB/PugFIDY5N/D9dFFtC0TMj4s=; b=T5jWUNLPIgzUEWCO YsFZP+CS4VMpbQ/xEFui0SEFnCAKNbGI5QmWXBBkQ+ZyxKd+J4h0xxNIV7Gl1o7T fcDnzMkrWCJlwfxc4lmtKKgMS5GF3MNzYxMsR5pY4rXev0anmqlz1fv9iTLMt7Vx TDjypI7+ml3QH9ddILkqT1ZrzZBI8Li0fvYWNy4ElqHvfrXPFWO9U2luOHnK8aTG iOqp2P5EQQburyIRHp3sEfmpsK1S7Ys57FN4nyJLkOqrGGEwc3kpyy1d6u7vj+X0 gAOZRUq8HMaqAIPQZhUogRgcbBqmOr0ziPiycE2AInccwaZWouaGfqPVw8ZRwS6q r/QS6A== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 451psv6unw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Feb 2025 21:43:59 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 8444C4004F; Wed, 26 Feb 2025 21:42:40 +0100 (CET) Received: by euls16034.sgp.st.com (STMicroelectronics, from userid 89) id 61EB44EECF2; Wed, 26 Feb 2025 19:14:28 +0100 (CET) Received: from Webmail-eu.st.com (eqndag1node4.st.com [10.75.129.133]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 2078A41E191; Wed, 26 Feb 2025 19:14:28 +0100 (CET) Received: from SAFDAG1NODE1.st.com (10.75.90.17) by EQNDAG1NODE4.st.com (10.75.129.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 26 Feb 2025 19:14:27 +0100 Received: from [10.48.86.222] (10.48.86.222) by SAFDAG1NODE1.st.com (10.75.90.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 26 Feb 2025 19:14:27 +0100 Message-ID: Date: Wed, 26 Feb 2025 19:14:26 +0100 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] pwm: stm32-lp: add support for stm32mp25 To: Krzysztof Kozlowski CC: , , , , , , , , , , , , , , , , , , References: <20250224180150.3689638-1-fabrice.gasnier@foss.st.com> <20250224180150.3689638-6-fabrice.gasnier@foss.st.com> <20250225-psychedelic-iguana-of-education-d5fff7@krzk-bin> Content-Language: en-US From: Fabrice Gasnier In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SAFDAG1NODE1.st.com (10.75.90.17) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-26_06,2025-02-26_01,2024-11-22_01 On 2/26/25 08:54, Krzysztof Kozlowski wrote: > On 25/02/2025 15:58, Fabrice Gasnier wrote: >> >> >> On 2/25/25 13:04, Krzysztof Kozlowski wrote: >>> On Mon, Feb 24, 2025 at 07:01:47PM +0100, Fabrice Gasnier wrote: >>>> } >>>> >>>> return pinctrl_pm_select_sleep_state(dev); >>>> @@ -246,6 +413,7 @@ static DEFINE_SIMPLE_DEV_PM_OPS(stm32_pwm_lp_pm_ops, stm32_pwm_lp_suspend, >>>> >>>> static const struct of_device_id stm32_pwm_lp_of_match[] = { >>>> { .compatible = "st,stm32-pwm-lp", }, >>>> + { .compatible = "st,stm32mp25-pwm-lp", }, >>> >>> No driver data suggests device is backwards compatible. Commit msg >>> suggests not, so that's confusing. >> >> >> The LPTimer PWM driver takes benefit of the MFD parent driver to feed in >> data, e.g. 'num_cc_chans'. Number of channels is now variable, on > > This means this ID table is useless. You do the matching via parent > device, so stop growing the table and call it deprecated or something. > >> STM32MP25 (e.g. not a single channel). But it can't be hard-coded as >> compatible data. (there's only 1 channel on earlier LP Timer hardware >> revision). >> >> The hardware controller is a bit different, hence the new compatible > > If it works with old compatible, it's an easy proof that it is > compatible, so please counter argument that with something specific. Ack, I'll drop the "st,stm32mp25-pwm-lp" compatible, as match through the parent device is achieved here. Alternatively, reading directly the hardware configuration register could be used to retrieve the 'num_cc_chans'. Thanks for reviewing, Best regards, Fabrice > What is different that driver cannot work with new device using old > interface or old features? > > > Best regards, > Krzysztof