From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20F941A01CC for ; Thu, 12 Sep 2024 13:51:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726149076; cv=none; b=sC7s4tPPG1bBdulV0fe+SPT3VRwum3vtn7xu2Zjf+HiHvN1jxKUPZv1ycIs2ckP+T79PWdT8SRlfQT1ku17gFXx1UJkGrbF/ArKNIJ6IpqZzemgluiWKmh/BhNJd5iML/gd8/an13kZbJ1zqnuvbAZPw65JIjL5ZDeaTNafaE9M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726149076; c=relaxed/simple; bh=mHXRZwn39XNfB4OE9L5AmkZEjp9sEoCwmPggRDBH4q0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qUcyl3JzpEQujdAnEk/I+M+xxOMbhbPdevwo0Jl9WFaMfnLE3DIlp7RuihaQbhBZoGV92ob2eee4KZT1huyAvKSHQ467WNcEOB6TPhjJyIchdhzLH+UHHawu2s7wbVc+fDmk8+Rma3nKTyF8o09JiZqO/OzRUs1suAkwg+Kx9lY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=K3MUaK3E; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="K3MUaK3E" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726149074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LJSgGclhv/0uXh5dllwuOUf6TENoJ6IQ0sOECsE/41c=; b=K3MUaK3EBnxTrf2iDDlMAu7YlUWjamXaGHKzW8W3dT3Ber3Cflv9WgSuRatNHn376KaLDC WcCJfqRP6l74YHT+zS5QUIdkxcj76CbwCvqqd/AlgH1YePJiOaIsOTD8v5akKCXtjVV4Bm kihEaNoogF4bsFCaZHWRlE7uqne+AkI= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-172-Kkq6mCHFO0ighjw99XHHHA-1; Thu, 12 Sep 2024 09:51:12 -0400 X-MC-Unique: Kkq6mCHFO0ighjw99XHHHA-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a8d15eff783so57860766b.3 for ; Thu, 12 Sep 2024 06:51:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726149072; x=1726753872; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LJSgGclhv/0uXh5dllwuOUf6TENoJ6IQ0sOECsE/41c=; b=P674M36aTtAyCEbVSe6vqm1g8Fky4vNQwLQtj885ESrYFIVCG37iqtZjCXpq0gKh6F hd/tLsQq6m8Vaf2IGz7B1v9a1T8hCShbRvPyE/+olLLC2tg2rD+5JIk1m0OZg0UgTC0F uwQxd2GVSL39CYDEE/u/MIw+X3bKLnEpPJaUqP+OZyPfBiSPQ1Nf92WN49+hKOdv2zTH 9p+rIRrnA+kCiMuGf+tOF/HwmoI7+E4JQLM7RwuMmqch25anHQknG4IDxf2hcpslWJjS GeAOfzRwgWG3Q2CB0QSeuUnmEh7aOpQG3MhSgMeycJ79bJIz7lGT8JfpnKfASRIFKyLk Jz8Q== X-Forwarded-Encrypted: i=1; AJvYcCVi94GxnHViIwt1F7oakknq+4zJEgc+D7fCbMcrovY4i+JZqzlxXSRgVBaP5ZHG1bAMEuq6dlzCT38=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/Lt7fP8kDssMhEe567vjMyiq7U9XzD525T3bbaa2tAxgWYNEB x7hakZvB1acOlLOy7VUM05/LzCd1b900yFzF7ztdrme/NvsaDX9F0QkipEnSUIHkctY54bCMPPp xfBpkW1EJazJdygS5oVDGzFhLiRM4w5A4dH0VCgMVgQ8qtG28sOx3mcb+UQ== X-Received: by 2002:a17:907:3f8d:b0:a90:1300:e613 with SMTP id a640c23a62f3a-a9029663045mr271614366b.55.1726149071588; Thu, 12 Sep 2024 06:51:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEwZn6v48IUSrL6GvIoE+fw0K59TC6eFg7FIafeKrAk88evG+6VkWRytIbWqBR+Xxkkjmikkg== X-Received: by 2002:a17:907:3f8d:b0:a90:1300:e613 with SMTP id a640c23a62f3a-a9029663045mr271611866b.55.1726149071028; Thu, 12 Sep 2024 06:51:11 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8d2597aca1sm748897266b.74.2024.09.12.06.51.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2024 06:51:10 -0700 (PDT) Message-ID: Date: Thu, 12 Sep 2024 15:51:09 +0200 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] iio: light: ltr501: Drop most likely fake ACPI ID To: Andy Shevchenko , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , Lars-Peter Clausen , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= References: <20240911212202.2892451-1-andriy.shevchenko@linux.intel.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20240911212202.2892451-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 9/11/24 11:22 PM, Andy Shevchenko wrote: > The commit in question does not proove that ACPI ID exists. > Quite likely it was a cargo cult addition while doint that > for DT-based enumeration. Drop most likely fake ACPI ID. > > Googling for LTERxxxx gives no useful results in regard to DSDT. > Moreover, there is no "LTER" official vendor ID in the registry. > > Signed-off-by: Andy Shevchenko Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/iio/light/ltr501.c | 23 ----------------------- > 1 file changed, 23 deletions(-) > > diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c > index 8c516ede9116..0e0420573286 100644 > --- a/drivers/iio/light/ltr501.c > +++ b/drivers/iio/light/ltr501.c > @@ -15,7 +15,6 @@ > #include > #include > #include > -#include > #include > > #include > @@ -1422,17 +1421,6 @@ static int ltr501_powerdown(struct ltr501_data *data) > data->ps_contr & ~LTR501_CONTR_ACTIVE); > } > > -static const char *ltr501_match_acpi_device(struct device *dev, int *chip_idx) > -{ > - const struct acpi_device_id *id; > - > - id = acpi_match_device(dev->driver->acpi_match_table, dev); > - if (!id) > - return NULL; > - *chip_idx = id->driver_data; > - return dev_name(dev); > -} > - > static int ltr501_probe(struct i2c_client *client) > { > const struct i2c_device_id *id = i2c_client_get_device_id(client); > @@ -1523,8 +1511,6 @@ static int ltr501_probe(struct i2c_client *client) > if (id) { > name = id->name; > chip_idx = id->driver_data; > - } else if (ACPI_HANDLE(&client->dev)) { > - name = ltr501_match_acpi_device(&client->dev, &chip_idx); > } else { > return -ENODEV; > } > @@ -1609,14 +1595,6 @@ static int ltr501_resume(struct device *dev) > > static DEFINE_SIMPLE_DEV_PM_OPS(ltr501_pm_ops, ltr501_suspend, ltr501_resume); > > -static const struct acpi_device_id ltr_acpi_match[] = { > - { "LTER0501", ltr501 }, > - { "LTER0559", ltr559 }, > - { "LTER0301", ltr301 }, > - { }, > -}; > -MODULE_DEVICE_TABLE(acpi, ltr_acpi_match); > - > static const struct i2c_device_id ltr501_id[] = { > { "ltr501", ltr501 }, > { "ltr559", ltr559 }, > @@ -1640,7 +1618,6 @@ static struct i2c_driver ltr501_driver = { > .name = LTR501_DRV_NAME, > .of_match_table = ltr501_of_match, > .pm = pm_sleep_ptr(<r501_pm_ops), > - .acpi_match_table = ltr_acpi_match, > }, > .probe = ltr501_probe, > .remove = ltr501_remove,