From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98CDBECAAD3 for ; Mon, 19 Sep 2022 15:56:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229902AbiISP4B (ORCPT ); Mon, 19 Sep 2022 11:56:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229842AbiISP4A (ORCPT ); Mon, 19 Sep 2022 11:56:00 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCF7E1182F for ; Mon, 19 Sep 2022 08:55:59 -0700 (PDT) Received: from canpemm500009.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MWTg92T0bzMn1g; Mon, 19 Sep 2022 23:51:17 +0800 (CST) Received: from [10.174.178.165] (10.174.178.165) by canpemm500009.china.huawei.com (7.192.105.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 19 Sep 2022 23:55:57 +0800 Subject: Re: [PATCH] iio: adc: ad7124: Silent no spi_device_id warnings To: Jonathan Cameron CC: Lars-Peter Clausen , Wei Yongjun , Michael Hennerich , References: <20220919145945.823327-1-weiyongjun@huaweicloud.com> <20220919165300.71e8012f@jic23-huawei> From: Wei Yongjun Message-ID: Date: Mon, 19 Sep 2022 23:55:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20220919165300.71e8012f@jic23-huawei> Content-Type: text/plain; charset="gbk" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.165] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500009.china.huawei.com (7.192.105.203) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On 2022/9/19 23:53, Jonathan Cameron wrote: > On Mon, 19 Sep 2022 22:50:35 +0800 > Wei Yongjun wrote: > >> On 2022/9/19 22:46, Lars-Peter Clausen wrote: >>> On 9/19/22 16:59, Wei Yongjun wrote: >>>> From: Wei Yongjun > Hi Wei Yongjun, > >>>> >>>> Add spi_device_id entries to silent following SPI warnings: > > silence rather than silent (also in patch titles) > >>>> >>>> SPI driver ad7124 has no spi_device_id for adi,ad7124-4 >>>> SPI driver ad7124 has no spi_device_id for adi,ad7124-8 >>> What generates those warnings? >>> >> >> Commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT >> compatible") added a test to check that every SPI driver has a >> spi_device_id for each DT compatiable string defined by the driver >> and warns if the spi_device_id is missing. > > When sending a series of similar fixes to a given subsystem together > it's helpful to group them into a series, so that comments that > apply series wide can easily be easily found. > > A cover letter is also useful to provide a little more information on > what is being fixed. Sure, will update in v3. Thanks.