From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Paller, Kim Seer" <KimSeer.Paller@analog.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: frequency: add admfm2000
Date: Tue, 21 Nov 2023 16:11:57 +0100 [thread overview]
Message-ID: <c6ed6ff6-5304-43e2-a434-bd024363da4e@linaro.org> (raw)
In-Reply-To: <PH0PR03MB7141E0B29DFEEE16C4A5D27FF9BBA@PH0PR03MB7141.namprd03.prod.outlook.com>
On 21/11/2023 15:47, Paller, Kim Seer wrote:
>
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Tuesday, November 21, 2023 9:05 PM
>> To: Paller, Kim Seer <KimSeer.Paller@analog.com>
>> Cc: Jonathan Cameron <jic23@kernel.org>; Lars-Peter Clausen
>> <lars@metafoo.de>; Hennerich, Michael <Michael.Hennerich@analog.com>;
>> Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
>> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>;
>> linux-iio@vger.kernel.org; devicetree@vger.kernel.org; linux-
>> kernel@vger.kernel.org
>> Subject: Re: [PATCH v2 1/2] dt-bindings: iio: frequency: add admfm2000
>>
>> [External]
>>
>> On 21/11/2023 11:00, Kim Seer Paller wrote:
>>> Dual microwave down converter module with input RF and LO frequency
>>> ranges from 0.5 to 32 GHz and an output IF frequency range from 0.1 to
>>> 8 GHz. It consists of a LNA, mixer, IF filter, DSA, and IF amplifier
>>> for each down conversion path.
>>>
>>> Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
>>> ---
>>> V1 -> V2: Removed '|' after description. Specified the pins connected to
>>> the GPIOs. Added additionalProperties: false. Changed node name to
>> gpio.
>>
>> Why? Is this a GPIO? Your bindings title say this is a converter, not a
>> GPIO.
>
> I might have used an incorrect generic name, considering that it utilizes GPIOs
> for controlling both mode and attenuation. What would be the appropriate
> name to use in this context?
git grep @ -- Documentation/devictree/bindings/iio/frequency
I would go with converter.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-21 15:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 10:00 [PATCH v2 1/2] dt-bindings: iio: frequency: add admfm2000 Kim Seer Paller
2023-11-21 10:00 ` [PATCH v2 2/2] iio: frequency: admfm2000: New driver Kim Seer Paller
2023-11-21 10:57 ` [PATCH v2 1/2] dt-bindings: iio: frequency: add admfm2000 Rob Herring
2023-11-21 13:04 ` Krzysztof Kozlowski
2023-11-21 14:47 ` Paller, Kim Seer
2023-11-21 15:11 ` Krzysztof Kozlowski [this message]
2023-11-21 22:52 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6ed6ff6-5304-43e2-a434-bd024363da4e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=KimSeer.Paller@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).