Linux IIO development
 help / color / mirror / Atom feed
From: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matti Vaittinen <mazziesaccount@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Paul Gazzillo <paul@pgazz.com>
Cc: Matt Ranostay <matt@ranostay.sg>,
	Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: light: Avago APDS9306
Date: Fri, 27 Oct 2023 19:25:05 +1030	[thread overview]
Message-ID: <c71d095b-cd39-4c4d-a985-7032a1da49d9@tweaklogic.com> (raw)
In-Reply-To: <b030cb0a-7a15-4497-9b0f-75615694dc04@linaro.org>


>>   
>>   properties:
>>     compatible:
>> -    const: avago,apds9300
>> +    oneOf:
> 
> Drop
Sorry, do you mean I should not use the "oneOf"?
> 
>> +      - enum:
>> +          - avago,apds9300
>> +          - avago,apds9306
>> +          - avago,apds9960
> 
> I don't understand what is happening here. At all. Some compatibles are
> moved, some are added, nothing explains why you are doing it.
> 
> 
> Best regards,
> Krzysztof
> 
I have formatted the commit message wrongly, it will be fixed at once.
I am trying to add the support for all the three sensors in the same schema file.

Regards,
Subhajit Ghosh



  reply	other threads:[~2023-10-27  8:55 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-27  7:45 [PATCH v2 0/2] Support for Avago APDS9306 Ambient Light Sensor Subhajit Ghosh
2023-10-27  7:45 ` [PATCH v2 1/2] dt-bindings: iio: light: Avago APDS9306 Subhajit Ghosh
2023-10-27  8:11   ` Krzysztof Kozlowski
2023-10-27  8:55     ` Subhajit Ghosh [this message]
2023-10-27 11:03       ` Krzysztof Kozlowski
2023-10-28 13:29   ` Jonathan Cameron
2023-10-27  7:45 ` [PATCH v2 2/2] iio: light: Add support for APDS9306 Light Sensor Subhajit Ghosh
2023-10-27  8:13   ` Krzysztof Kozlowski
2023-10-27  8:42     ` Subhajit Ghosh
2023-10-27 11:04       ` Krzysztof Kozlowski
2023-10-27 11:42         ` Subhajit Ghosh
2023-10-28 13:36           ` Jonathan Cameron
2023-10-27 11:07   ` Andy Shevchenko
2023-10-27 11:36     ` Subhajit Ghosh
2023-10-28  6:29   ` kernel test robot
2023-10-28 15:20   ` Jonathan Cameron
2023-10-29 15:51     ` Matti Vaittinen
2023-10-30 10:21       ` Matti Vaittinen
2023-10-31  7:11         ` Matti Vaittinen
2023-10-31  8:20           ` Subhajit Ghosh
2023-10-31 10:38           ` Andy Shevchenko
2023-10-31 11:39             ` Matti Vaittinen
2023-10-31 12:07             ` Matti Vaittinen
2023-10-31 13:42               ` Andy Shevchenko
2023-11-01  6:16                 ` Matti Vaittinen
2023-11-02 12:50                   ` Andy Shevchenko
2023-10-31  8:38     ` Subhajit Ghosh
2023-11-06 11:13       ` Jonathan Cameron
2023-11-06 12:04         ` Subhajit Ghosh
2023-11-06 12:10           ` Matti Vaittinen
2023-12-04  9:51             ` Jonathan Cameron
2023-11-05 14:22   ` kernel test robot
2023-11-06 10:07     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c71d095b-cd39-4c4d-a985-7032a1da49d9@tweaklogic.com \
    --to=subhajit.ghosh@tweaklogic.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@ranostay.sg \
    --cc=mazziesaccount@gmail.com \
    --cc=paul@pgazz.com \
    --cc=robh+dt@kernel.org \
    --cc=stefan.windfeldt-prytz@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox