From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E96E1DEFE2 for ; Wed, 4 Sep 2024 15:00:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725462049; cv=none; b=h6BWMLJi2Qk7XQbfjxCT+vxffwLXanSHyaBILWoorouLsUqX4WtDKyEIsp68uqdJIaJNk6jQiROCltKmX2bhWOtq04HSQpRUNmqnKhckaO42I2PO+bkrV8OT0tLQjCOj9tvhh3Ff1HPabhntAryDOZ+QPkc6Ijcdx6yNDtMChas= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725462049; c=relaxed/simple; bh=mpaSKPKFI7tkspiAnYFGKulU+AEB1UnWK48DA9f4sMo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Bk9pQlMBwvH3Q2A8j6PSwoYJzBVQuEn2/28PpL+aWngxDZ8M3QzuxnzTv1MRNQC1mnC+WHaONwveFZoj5YNvnZpFWeg+dR6lDIa/sN0KT8zJEQ5Zj77Py86KdKQZyrIP22JZmgDmrJcOuPlFD4kPvvYRAk03tp6N9oLqVEMvhaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=lwjp0HTV; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="lwjp0HTV" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-70f794cd240so1828030a34.0 for ; Wed, 04 Sep 2024 08:00:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1725462045; x=1726066845; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3Q3wt1eu/qt5c++yS22ZxXYczo7g4ms6we1XeaOrheI=; b=lwjp0HTV4fIyHVeBm99jf8//Ujos/vlfESi/Of4xSX+s3DAcdnY/3a3Gw6h7U1F9Em 17h96TEXT1KW4kFoRaVttDVm3l9DgF3XRFH748PEMApUlIFwyv6HPGGIfFAf0ghkjbpl gT0tTRo4wp7AyAPLKcZfL4G1xMNxbwymTDO6F0+HoH6tRvb74Q9ep8QpOZKI9CZ4Q0vh FL/sK5CHP3hLZ+75GISinKSRUbRiFABfyCUUgOyGeD45QH8bDHl2a8wwJQHV9D/vpeK+ iPMJePEYj9aR7eM/O5JZ0v/4FCD+4S0YKR8MFjfnXYtzO7j0uhSd7NjZd2m/CkLO1btG lZ6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725462045; x=1726066845; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3Q3wt1eu/qt5c++yS22ZxXYczo7g4ms6we1XeaOrheI=; b=iblqsb2MWIj8bgGriEG5jXw4cQFdOtmMlT5B6B6gIOXPpJRJFSun3L2xx62YryKgDg BwjhoHivwrOwKNlrFV34len9ThpOiWuyUJI09oXmMv9MHgnWSsY4vTaoV29S8kt6R85O SH4ujkxSjN4YZ2KstjCkAD/8yPY/qqThMLzSRp+arepmPqrLnB7OrpaWWfXqCgvqSKZp LMUqXy7PWfzfAX4qpU2UTedRo7IOgUSgxBXgvTYwSU9p54im5D4tKCvFMvE2yWvihmjN Y+gBwaJjp8/XW7kkUfJ7KQW6TvdP8iLnNHDwY3JLktaBzJeySzh31vZgYuu5wkCvHDoz 9yfg== X-Forwarded-Encrypted: i=1; AJvYcCXZ1zZ8PidgOWFQbLm7mltALsjyN+PS8UqTNAxSW5Dj6hX13o6KZCQ7VO+ZzlNvJBwTfmJlny17me4=@vger.kernel.org X-Gm-Message-State: AOJu0YyfjY1XIwR4RuXM9OaY3ugmd69ZmKCjEntbjKLarT5XC/u9yTmr UzTxD8AqwpnsaIM/+JjMCVG+VAAhJ8RSy0a48vt5hNaUOxvbtJkjqnjK4Z/uvaw= X-Google-Smtp-Source: AGHT+IHmzGse6HO1ACq+epnsUcfoBMuqLbNt/vcRJ4ioIq1Zdys0uq813fa7U3aDwVCrwXTEeHW1wg== X-Received: by 2002:a05:6830:4906:b0:709:48b3:7d91 with SMTP id 46e09a7af769-70f72b7a9efmr17607571a34.6.1725462044538; Wed, 04 Sep 2024 08:00:44 -0700 (PDT) Received: from [192.168.40.12] (d24-150-219-207.home.cgocable.net. [24.150.219.207]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6c340bff7b6sm64592156d6.43.2024.09.04.08.00.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2024 08:00:44 -0700 (PDT) Message-ID: Date: Wed, 4 Sep 2024 11:00:42 -0400 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] iio: adc: ad7625: add driver To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Cc: kernel test robot , Lars-Peter Clausen , Michael Hennerich , =?UTF-8?Q?Nuno_S=C3=A1?= , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , David Lechner , oe-kbuild-all@lists.linux.dev, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20240819-ad7625_r1-v3-2-75d5217c76b5@baylibre.com> <202408201520.lFtco3eF-lkp@intel.com> <7658aca4-a408-480c-98b6-4637bb86b5ad@baylibre.com> Content-Language: en-US From: Trevor Gamblin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2024-09-04 3:58 a.m., Uwe Kleine-König wrote: > Hi Trevor, > > On Tue, Aug 20, 2024 at 05:07:27PM -0400, Trevor Gamblin wrote: >> On 2024-08-20 3:19 a.m., kernel test robot wrote: >>> Hi Trevor, >>> >>> kernel test robot noticed the following build errors: >>> >>> [auto build test ERROR on ac6a258892793f0a255fe7084ec2b612131c67fc] >>> >>> url: https://github.com/intel-lab-lkp/linux/commits/Trevor-Gamblin/dt-bindings-iio-adc-add-AD762x-AD796x-ADCs/20240819-221425 >>> base: ac6a258892793f0a255fe7084ec2b612131c67fc >>> patch link: https://lore.kernel.org/r/20240819-ad7625_r1-v3-2-75d5217c76b5%40baylibre.com >>> patch subject: [PATCH v3 2/3] iio: adc: ad7625: add driver >>> config: alpha-randconfig-r132-20240820 (https://download.01.org/0day-ci/archive/20240820/202408201520.lFtco3eF-lkp@intel.com/config) >>> compiler: alpha-linux-gcc (GCC) 13.3.0 >>> reproduce: (https://download.01.org/0day-ci/archive/20240820/202408201520.lFtco3eF-lkp@intel.com/reproduce) >> Seems to be a problem with missing static inline definitions in pwm.h if >> CONFIG_PWM isn't set. I've replied to the relevant series on the PWM mailing >> list and will add "select PWM" to Kconfig for this driver. > I'm not a big fan of the dummy static inlines. It seems to be a somewhat > subjective thing, but I think that usually if a driver makes use of PWM > functions it doesn't work at all if CONFIG_PWM=n. Does your driver work > with CONFIG_PWM=n? If not, even if the dummy inline was there, I'd > recommend at least a No, it won't build without pwm_round_waveform_might_sleep() and pwm_set_waveform_might_sleep(), which setting CONFIG_PWM=n seems to hide. I'll add depends on PWM to the next round of the patch series. Thanks! > > depends on PWM || COMPILE_TEST > > . (This is also the implicit recommendation to use "depends" and not > "select". Currently all drivers needing PWM use "depends" and mixing > yields strange effects in menuconfig.) > > Currently there is only a single driver that uses "depends on PWM || > COMPILE_TEST" (i.e. SENSORS_PWM_FAN). I already considered changing that > to plain "depends on PWM" and get rid of the dummy defines. While I > didn't tackle that one yet, I'd like to not introduce dummys for the new > waveform functions. So I suggest you either stick to > > depends on PWM > > or try to convince me that these dummys are a good idea (and then > probably use "... || COMPILE_TEST"). > > Best regards > Uwe