From: "Nuno Sá" <noname.nuno@gmail.com>
To: "David Lechner" <dlechner@baylibre.com>,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Andy Shevchenko" <andy@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7380: remove unused oversampling_ratio getter
Date: Fri, 27 Jun 2025 16:56:55 +0100 [thread overview]
Message-ID: <cd0b9044ce6434e9313a4fddf73897800821aec3.camel@gmail.com> (raw)
In-Reply-To: <20250624-iio-adc-ad7380-remove-unused-oversampling_ratio-getter-v1-1-26cbee356860@baylibre.com>
On Tue, 2025-06-24 at 22:44 +0000, David Lechner wrote:
> Remove a call to ad7380_get_osr() in ad7380_init_offload_msg. The
> returned value is never used.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> I wrote this a while back but it looks like it never got sent so here
> it is now.
> ---
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> drivers/iio/adc/ad7380.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7380.c b/drivers/iio/adc/ad7380.c
> index
> d96bd12dfea632b62475d6537c8d6601b042de1f..abcd4cc70074723303b9b67e2b89b0c4b43c
> 6884 100644
> --- a/drivers/iio/adc/ad7380.c
> +++ b/drivers/iio/adc/ad7380.c
> @@ -1165,7 +1165,6 @@ static int ad7380_init_offload_msg(struct ad7380_state
> *st,
> struct spi_transfer *xfer = &st->offload_xfer;
> struct device *dev = &st->spi->dev;
> const struct iio_scan_type *scan_type;
> - int oversampling_ratio;
> int ret;
>
> scan_type = iio_get_current_scan_type(indio_dev,
> @@ -1195,10 +1194,6 @@ static int ad7380_init_offload_msg(struct ad7380_state
> *st,
> }
> }
>
> - ret = ad7380_get_osr(st, &oversampling_ratio);
> - if (ret)
> - return ret;
> -
> xfer->bits_per_word = scan_type->realbits;
> xfer->offload_flags = SPI_OFFLOAD_XFER_RX_STREAM;
> xfer->len = AD7380_SPI_BYTES(scan_type) * st->chip_info-
> >num_simult_channels;
>
> ---
> base-commit: b57cb7c47e31244bef6612f271c5dc390f761e17
> change-id: 20250624-iio-adc-ad7380-remove-unused-oversampling_ratio-getter-
> e54413627fe0
>
> Best regards,
next prev parent reply other threads:[~2025-06-27 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 22:44 [PATCH] iio: adc: ad7380: remove unused oversampling_ratio getter David Lechner
2025-06-27 15:56 ` Nuno Sá [this message]
2025-06-28 15:30 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd0b9044ce6434e9313a4fddf73897800821aec3.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox