linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
To: jic23@kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de
Cc: linux-iio@vger.kernel.org, srinivas.pandruvada@linux.intel.com,
	sathyanarayanan.kuppuswamy@linux.intel.com
Subject: [PATCH v7 0/1] iio: jsa1212: Add JSA1212 proximity/ALS sensor
Date: Mon, 15 Sep 2014 20:54:07 -0700	[thread overview]
Message-ID: <cover.1410839445.git.sathyanarayanan.kuppuswamy@linux.intel.com> (raw)

Please let me know your review comments.

PATCH v7 changes:

Fixed a check patch warning.

PATCH v6 changes:

Addressed comments from Peter & Hartmut. Mainly, 
1. Removed duplicate header files
2. Renamed IRDR settings macro names
3. Simplified endian conversion expression
4. Refactored the code in many sections to remove
   unncessary breaks statements and returns.
5. Renamed jsa1212 priv data variable name in probe function.

PATCH v5 changes:

1. Removed irq.h and interrupt.h.
2. Disabled the device under error condition when reading data.
3. Added TODO and slave address info in file header.

PATCH v4 changes:

1. Removed unused register defines
2. Used standard endian conversion function instead of custom one.
3. Replaced register default value constants with appropriate bit value macros.
4. Removed iio user interfaces before powering off the device in remove function.

PATCH v3 changes:

1. Replaced status flags with bool values.
2. Added regmap suppport to avoid adding custom i2c register update routine.
3. Also addressed some minor comments from Jonathan Cameron

PATCH v2 changes:

1. Combined ALS/PXS enable/disable functions into a single routine.
2. Removed extra debug messages.
3. Also addressed review comments from Peter Meerwald

Kuppuswamy Sathyanarayanan (1):
  iio: jsa1212: Add JSA1212 proximity/ALS sensor

 drivers/iio/light/Kconfig   |  10 +
 drivers/iio/light/Makefile  |   1 +
 drivers/iio/light/jsa1212.c | 471 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 482 insertions(+)
 create mode 100644 drivers/iio/light/jsa1212.c

-- 
1.9.1


             reply	other threads:[~2014-09-16  3:58 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-16  3:54 Kuppuswamy Sathyanarayanan [this message]
2014-09-16  3:54 ` [PATCH v7 1/1] iio: jsa1212: Add JSA1212 proximity/ALS sensor Kuppuswamy Sathyanarayanan
2014-09-17 20:48   ` Hartmut Knaack
2014-09-17 20:59     ` sathyanarayanan kuppuswamy
2014-09-21 12:52       ` Jonathan Cameron
2014-09-29 22:00         ` sathyanarayanan kuppuswamy
2014-10-07 20:09           ` sathyanarayanan kuppuswamy
2014-10-09 19:26             ` Jonathan Cameron
2014-10-11 14:57               ` Srinivas Pandruvada
2014-10-14 16:38                 ` sathyanarayanan kuppuswamy
2014-10-14 17:38                   ` Jonathan Cameron
2014-11-05 16:11                     ` Jonathan Cameron
2014-11-05 23:26                       ` Hartmut Knaack
2014-11-06 12:09                         ` Srinivas Pandruvada
2014-11-08 12:25                           ` Jonathan Cameron
2014-11-08 23:33                           ` Hartmut Knaack
2014-11-10 17:35                             ` Srinivas Pandruvada
2014-11-29 10:52                               ` Hartmut Knaack
2014-12-01 16:58                                 ` Srinivas Pandruvada
2014-12-02 22:47                                   ` sathyanarayanan kuppuswamy
2014-12-08 19:51                                     ` sathyanarayanan kuppuswamy
2014-12-09 22:59                                       ` Hartmut Knaack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1410839445.git.sathyanarayanan.kuppuswamy@linux.intel.com \
    --to=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).