linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Barry Song <21cnbao@gmail.com>, John Syne <john3909@gmail.com>
Cc: daniel.baluta@nxp.com, linux-iio@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/7] staging:iio:ade7854: Cleanup on I2C/SPI code
Date: Wed, 14 Mar 2018 15:10:00 -0300	[thread overview]
Message-ID: <cover.1521037060.git.rodrigosiqueiramelo@gmail.com> (raw)

This patchset reworks the I2C/SPI code from meter module. The set of
patches try to reduce the code duplication and make the communication
reliable. The current version of the module had many code duplications,
which make the code more error-prone and hard to read. Jonh Syne
identified some wrong error handling and fixed it in his patches; in
this series of patches I analyzed Jonh's fixes, and use it in the new
code.

It is important to highlight that meter module is under observation, due
to the lack of hardware and the old design of the chip. However, John
has the hardware for testing and interest to help to update the code
[1]. As a result, this patchset represents the first work effort to
update the meter module in the staging.

1 - https://marc.info/?l=linux-iio&m=152046885922153&w=2 

Rodrigo Siqueira (7):
  staging:iio:ade7854: Rework I2C write function
  staging:iio:ade7854: Rework SPI write function
  staging:iio:ade7854: Replace many functions for one function
  staging:iio:ade7854: Rework I2C read function
  staging:iio:ade7854: Rework SPI read function
  staging:iio:ade7854: Remove read_reg_* duplications
  staging:iio:ade7854: Add proper error handling condition.

 drivers/staging/iio/meter/ade7854-i2c.c | 236 ++++++++--------------------
 drivers/staging/iio/meter/ade7854-spi.c | 268 +++++++-------------------------
 drivers/staging/iio/meter/ade7854.c     |  44 +++---
 drivers/staging/iio/meter/ade7854.h     |  23 +--
 4 files changed, 160 insertions(+), 411 deletions(-)

-- 
2.16.2

             reply	other threads:[~2018-03-14 18:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14 18:10 Rodrigo Siqueira [this message]
2018-03-14 18:10 ` [PATCH 1/7] staging:iio:ade7854: Rework I2C write function Rodrigo Siqueira
2018-03-15 12:06   ` Dan Carpenter
2018-03-16  0:25     ` Rodrigo Siqueira
2018-03-14 18:10 ` [PATCH 2/7] staging:iio:ade7854: Rework SPI " Rodrigo Siqueira
2018-03-14 18:10 ` [PATCH 3/7] staging:iio:ade7854: Replace many functions for one function Rodrigo Siqueira
2018-03-14 18:11 ` [PATCH 4/7] staging:iio:ade7854: Rework I2C read function Rodrigo Siqueira
2018-03-14 18:11 ` [PATCH 5/7] staging:iio:ade7854: Rework SPI " Rodrigo Siqueira
2018-03-14 18:11 ` [PATCH 6/7] staging:iio:ade7854: Remove read_reg_* duplications Rodrigo Siqueira
2018-03-14 18:12 ` [PATCH 7/7] staging:iio:ade7854: Add proper error handling condition Rodrigo Siqueira
2018-03-15 12:11   ` Dan Carpenter
2018-03-16  0:28     ` Rodrigo Siqueira
2018-03-16  8:02       ` Dan Carpenter
2018-03-16 13:59         ` Rodrigo Siqueira
2018-03-16 14:17           ` Dan Carpenter
2018-03-16 20:03             ` Rodrigo Siqueira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1521037060.git.rodrigosiqueiramelo@gmail.com \
    --to=rodrigosiqueiramelo@gmail.com \
    --cc=21cnbao@gmail.com \
    --cc=daniel.baluta@nxp.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=john3909@gmail.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).