Re: [PATCH v3 5/6] dt-bindings: iio: adc: Add AD4000

Conor Dooley
2024-06-07T14:49:10Z

[-- Attachment #1: Type: text/plain, Size: 1693 bytes --]

On Fri, Jun 07, 2024 at 11:35:44AM -0300, Marcelo Schmitt wrote:
> On 06/05, Conor Dooley wrote:
> > On Tue, Jun 04, 2024 at 07:43:53PM -0300, Marcelo Schmitt wrote:
> > > Add device tree documentation for AD4000 series of ADC devices.
> > > +properties:
> > > + compatible:
> > > + enum:
> > > + - adi,ad4000
> > > + - adi,ad4001
> > > + - adi,ad4002
> > > + - adi,ad4003
> > > + - adi,ad4004
> > > + - adi,ad4005
> > > + - adi,ad4006
> > > + - adi,ad4007
> > > + - adi,ad4008
> > > + - adi,ad4010
> > > + - adi,ad4011
> > > + - adi,ad4020
> > > + - adi,ad4021
> > > + - adi,ad4022
> > > + - adi,adaq4001
> > > + - adi,adaq4003
> >
> > Are all these actually incompatible? I'd like a note in the commit
> > message as to why that's the case. A quick look at the driver showed
> > that the differences in the driver between the ad402{0,1,2} are limited
> > to the "dev_name". Same went for some other devices, like the
> > ad40{02,06,10}.
>
> Yes, that's correct. Some chips only vary by name and max sample rate which
> boils down to only having a different dev_name in the driver.
> Can those have grouped compatible strings?
> dt_binding_check fails if curly brackets are used.
> properties:
> compatible:
> enum:
> - adi,ad402{0,1,2}

compatible:
oneOf:
- const: adi,ad4020
- items:
- enum:
- adi,ad4021
- adi,ad4022
- const: adi,ad4020

>
> The groups of similar chips are:
> AD4020/AD4021/AD4022
> AD4003/AD4007/AD4011
> AD4002/AD4006/AD4010
> AD4001/AD4005
> AD4000/AD4004/AD4008

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]