Re: [PATCH v5 5/7] dt-bindings: iio: adc: Add AD4000

Conor Dooley
2024-06-26T11:34:45Z

[-- Attachment #1: Type: text/plain, Size: 3457 bytes --]

On Tue, Jun 25, 2024 at 06:55:03PM -0300, Marcelo Schmitt wrote:
> Add device tree documentation for AD4000 series of ADC devices.
>
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
> ---
> .../bindings/iio/adc/adi,ad4000.yaml | 190 ++++++++++++++++++
> MAINTAINERS | 7 +
> 2 files changed, 197 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml
> new file mode 100644
> index 000000000000..76035dff5474
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml
> @@ -0,0 +1,190 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/adi,ad4000.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD4000 and similar Analog to Digital Converters
> +
> +maintainers:
> + - Marcelo Schmitt <marcelo.schmitt@analog.com>
> +
> +description: |
> + Analog Devices AD4000 family of Analog to Digital Converters with SPI support.
> + Specifications can be found at:
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4000-4004-4008.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4001-4005.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4002-4006-4010.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4003-4007-4011.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4020-4021-4022.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/adaq4001.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/adaq4003.pdf
> +
> +$ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: adi,ad4000
> + - items:
> + - enum:
> + - adi,ad4004
> + - adi,ad4008
> + - const: adi,ad4000

> + - const: adi,ad4001
> + - items:
> + - enum:
> + - adi,ad4005
> + - const: adi,ad4001

> + - const: adi,ad4002
> + - items:
> + - enum:
> + - adi,ad4006
> + - adi,ad4010
> + - const: adi,ad4002

> + - const: adi,ad4003
> + - items:
> + - enum:
> + - adi,ad4007
> + - adi,ad4011
> + - const: adi,ad4003

> + - const: adi,ad4020
> + - items:
> + - enum:
> + - adi,ad4021
> + - adi,ad4022
> + - const: adi,ad4020

> + - const: adi,adaq4001

> + - const: adi,adaq4003

I think some blank lines, maybe like the above, would go a long way with
this list of compatibles.

> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 102040816 # for VIO > 2.7 V, 81300813 for VIO > 1.7 V
> +
> + adi,sdi-pin:
> + $ref: /schemas/types.yaml#/definitions/string
> + enum: [ high, low, cs ]

enum: [ high, low, cs, sdi ]
default: sdi

I'd do this, so that the default is documented in the binding, not in
the description text.

Otherwise, this looks good to me.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]