Re: [PATCH v5 5/7] dt-bindings: iio: adc: Add AD4000

Marcelo Schmitt
2024-06-26T13:33:01Z

On 06/26, Conor Dooley wrote:
> On Tue, Jun 25, 2024 at 06:55:03PM -0300, Marcelo Schmitt wrote:
> > Add device tree documentation for AD4000 series of ADC devices.
> >
> > Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
> > ---
> > .../bindings/iio/adc/adi,ad4000.yaml | 190 ++++++++++++++++++
> > MAINTAINERS | 7 +
...
> > +properties:
> > + compatible:
> > + oneOf:
> > + - const: adi,ad4000
> > + - items:
> > + - enum:
> > + - adi,ad4004
> > + - adi,ad4008
> > + - const: adi,ad4000
>
> > + - const: adi,ad4001
> > + - items:
> > + - enum:
> > + - adi,ad4005
> > + - const: adi,ad4001
>
> > + - const: adi,ad4002
> > + - items:
> > + - enum:
> > + - adi,ad4006
> > + - adi,ad4010
> > + - const: adi,ad4002
>
> > + - const: adi,ad4003
> > + - items:
> > + - enum:
> > + - adi,ad4007
> > + - adi,ad4011
> > + - const: adi,ad4003
>
> > + - const: adi,ad4020
> > + - items:
> > + - enum:
> > + - adi,ad4021
> > + - adi,ad4022
> > + - const: adi,ad4020
>
> > + - const: adi,adaq4001
>
> > + - const: adi,adaq4003
>
> I think some blank lines, maybe like the above, would go a long way with
> this list of compatibles.
>
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + spi-max-frequency:
> > + maximum: 102040816 # for VIO > 2.7 V, 81300813 for VIO > 1.7 V
> > +
> > + adi,sdi-pin:
> > + $ref: /schemas/types.yaml#/definitions/string
> > + enum: [ high, low, cs ]
>
> enum: [ high, low, cs, sdi ]
> default: sdi
>
> I'd do this, so that the default is documented in the binding, not in
> the description text.
>
> Otherwise, this looks good to me.

Ack, will do.
Thanks