From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Cosmin Tanislav <cosmin.tanislav@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Michael Walle <michael@walle.cc>, Nuno Sa <nuno.sa@analog.com>,
Andy Shevchenko <andy@kernel.org>,
Dumitru Ceclan <mitrutzceclan@gmail.com>
Cc: linux-iio@vger.kernel.org
Subject: [PATCH 0/2] iio: adc: ad*: Fix comparisons using memcmp
Date: Thu, 30 Jan 2025 18:45:00 +0100 [thread overview]
Message-ID: <cover.1738258777.git.u.kleine-koenig@baylibre.com> (raw)
Hello,
I recently sent a patch fixing a bad coding pattern in the ad7124
driver; see
https://lore.kernel.org/linux-iio/20250124160124.435520-2-u.kleine-koenig@baylibre.com/.
The same pattern is used for ad4130 and ad7173. This series fixes these
two drivers in the same way. As for the ad7124 driver this didn't break
in production and if the memcmp comparison wrongly returns false,
nothing bad happens. Only usage of the resources isn't optimal then but
that is probably nothing a user would notice. So there is no urge here.
Still it's the correct thing to do to drop the comparison using memcmp
and compare member-by-member instead.
Best regards
Uwe
Uwe Kleine-König (2):
iio: adc: ad4130: Fix comparison of channel setups
iio: adc: ad7173: Fix comparison of channel configs
drivers/iio/adc/ad4130.c | 33 +++++++++++++++++++++++++++++++--
drivers/iio/adc/ad7173.c | 15 ++++++++++++---
2 files changed, 43 insertions(+), 5 deletions(-)
base-commit: a13f6e0f405ed0d3bcfd37c692c7d7fa3c052154
--
2.47.1
next reply other threads:[~2025-01-30 17:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 17:45 Uwe Kleine-König [this message]
2025-01-30 17:45 ` [PATCH 1/2] iio: adc: ad4130: Fix comparison of channel setups Uwe Kleine-König
2025-01-30 18:08 ` Andy Shevchenko
2025-01-30 18:14 ` Andy Shevchenko
2025-02-12 9:01 ` Uwe Kleine-König
2025-02-13 14:14 ` Nuno Sá
2025-01-30 17:45 ` [PATCH 2/2] iio: adc: ad7173: Fix comparison of channel configs Uwe Kleine-König
2025-01-30 18:11 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1738258777.git.u.kleine-koenig@baylibre.com \
--to=u.kleine-koenig@baylibre.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=cosmin.tanislav@analog.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=michael@walle.cc \
--cc=mitrutzceclan@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).