From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Nuno Sa <nuno.sa@analog.com>,
David Lechner <dlechner@baylibre.com>,
Javier Carrasco <javier.carrasco.cruz@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/7] Support ROHM BD79104 ADC
Date: Wed, 2 Apr 2025 09:07:46 +0300 [thread overview]
Message-ID: <cover.1743573284.git.mazziesaccount@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2397 bytes --]
The ROHM BD79104 ADC is a 12 bit, 8-channel ADC controlled via SPI.
The communication over SPI uses similar protocol as the ti-adc128s052.
In order to avoid code duplication, the support for the ROHM IC is
added in the same driver.
The driver side differencies between the ti-adc128s052 and the ROHM
BD79104 are related to the supply regulator handling. The BD79104
requires supplies for the VDD and IOVDD. The ti-adc128s052 driver
handles only the reference voltage supply, even though the TI data-sheet
indicates it can also have separate supplies.
Hardware vise the ROHM BD79104 requires SPI MODE 3, and has also some SPI
frequency limitations.
I decided to add own binding document for the ROHM BD79104 so it is
easier to document the SPI limitations. It also allows using the supply
names from the data sheet. And finally, it gives users of this IC a
better hint that it is supported.
Finally, I didn't find maintainer information for this driver from the
MAINTAINERS file. I would like to add myself as a reviewer for the
driver, so I can stay on track of the changes to it. AFAIR, having
R-entry without M-entry was not appreciated. Any suggestions how to
handle this?
This series was based on the v6.14, but it should apply cleanly on
iio/testing - please let me know if I should rebase.
Revision history:
v1 => v2:
- Drop the claim that original driver is broken for BE and rename the
patch 0001 accordingly
- Fix race when filling the SPI message
- Check return value for the devm_mutex_init()
- Add a RFC patch for dropping the support for variable Vref.
---
Matti Vaittinen (7):
dt-bindings: ROHM BD79104 ADC
iio: adc: ti-adc128s052: Simplify using be16_to_cpu()
iio: adc: ti-adc128s052: Be consistent with arrays
iio: adc: ti-adc128s052: Use devm_mutex_init()
iio: adc: ti-adc128s052: Simplify using guard(mutex)
iio: adc: ti-adc128s052: Support ROHM BD79104
iio: ti-adc128s052: Drop variable vref
.../bindings/iio/adc/rohm,bd79104.yaml | 69 +++++++++++++
drivers/iio/adc/Kconfig | 2 +-
drivers/iio/adc/ti-adc128s052.c | 99 +++++++++++--------
3 files changed, 130 insertions(+), 40 deletions(-)
create mode 100644 Documentation/devicetree/bindings/iio/adc/rohm,bd79104.yaml
base-commit: 543da6252b48bbfe13e194fb980bdd2b161f6838
--
2.49.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2025-04-02 6:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 6:07 Matti Vaittinen [this message]
2025-04-02 6:08 ` [PATCH v2 1/7] dt-bindings: ROHM BD79104 ADC Matti Vaittinen
2025-04-02 6:09 ` [PATCH v2 2/7] iio: adc: ti-adc128s052: Simplify using be16_to_cpu() Matti Vaittinen
2025-04-02 21:04 ` David Lechner
2025-04-03 5:16 ` Matti Vaittinen
2025-04-05 17:29 ` Jonathan Cameron
2025-04-07 5:23 ` Matti Vaittinen
2025-04-07 18:49 ` Jonathan Cameron
2025-04-02 6:09 ` [PATCH v2 3/7] iio: adc: ti-adc128s052: Be consistent with arrays Matti Vaittinen
2025-04-02 6:09 ` [PATCH v2 4/7] iio: adc: ti-adc128s052: Use devm_mutex_init() Matti Vaittinen
2025-04-02 6:09 ` [PATCH v2 5/7] iio: adc: ti-adc128s052: Simplify using guard(mutex) Matti Vaittinen
2025-04-02 6:10 ` [PATCH v2 6/7] iio: adc: ti-adc128s052: Support ROHM BD79104 Matti Vaittinen
2025-04-02 6:10 ` [PATCH RFC v2 7/7] iio: ti-adc128s052: Drop variable vref Matti Vaittinen
2025-04-02 20:49 ` David Lechner
2025-04-03 5:18 ` Matti Vaittinen
2025-04-05 16:25 ` Jonathan Cameron
2025-04-02 6:19 ` [PATCH v2 0/7] Support ROHM BD79104 ADC Matti Vaittinen
2025-04-05 17:36 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1743573284.git.mazziesaccount@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).