From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>, Sergio Perez <sergio@pereznus.es>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: light: bh1750: Add hardware reset support via GPIO
Date: Tue, 18 Mar 2025 08:18:23 +0100 [thread overview]
Message-ID: <d23d7979-1dee-4c46-954a-3617d8cf5604@kernel.org> (raw)
In-Reply-To: <20250317115815.2416c741@jic23-huawei>
On 17/03/2025 12:58, Jonathan Cameron wrote:
>> + reset-gpios:
>> + description: GPIO connected to the sensor's reset line (active low)
>> + maxItems: 1
>>
>> required:
>> - compatible
>> @@ -41,5 +48,16 @@ examples:
>> reg = <0x23>;
>> };
>> };
>> + - |
>> + i2c {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + light-sensor@23 {
>> + compatible = "rohm,bh1750";
>> + reg = <0x23>;
>> + reset-gpios = <&gpio2 17 GPIO_ACTIVE_HIGH>;
> Add the GPIO to the existing example rather than having a new one.
... and it is weird to see you claim here is ACTIVE_HIGH but in
description you say active low. It's possible, but unlikely. More likely
this is just wrong, so use proper flag.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-18 7:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-16 14:55 [PATCH] iio: light: bh1750: Add hardware reset support via GPIO Sergio Perez
2025-03-17 7:24 ` Krzysztof Kozlowski
[not found] ` <64182937-29e9-45dc-aa2f-5f2b739056a1@me.com>
2025-03-18 13:28 ` Krzysztof Kozlowski
2025-03-18 14:16 ` Sergio Pérez
2025-03-18 15:16 ` Krzysztof Kozlowski
2025-03-18 16:06 ` Sergio Pérez
2025-03-18 16:21 ` Krzysztof Kozlowski
2025-03-18 16:23 ` Krzysztof Kozlowski
2025-03-18 17:26 ` Sergio Pérez
2025-03-18 17:37 ` Krzysztof Kozlowski
2025-03-18 19:51 ` Sergio Pérez
2025-03-20 7:15 ` Krzysztof Kozlowski
2025-03-19 8:46 ` Krzysztof Kozlowski
2025-03-19 16:26 ` Sergio Pérez
2025-03-20 7:18 ` Krzysztof Kozlowski
2025-03-17 11:58 ` Jonathan Cameron
2025-03-18 7:18 ` Krzysztof Kozlowski [this message]
2025-03-18 14:35 ` Sergio Pérez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d23d7979-1dee-4c46-954a-3617d8cf5604@kernel.org \
--to=krzk@kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=sergio@pereznus.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox