Re: [PATCH v3 5/5] iio: adc: ad7606: add gain calibration support

[David Lechner <dlechner@baylibre.com>]

On 5/8/25 11:27 AM, David Lechner wrote:
> On 5/8/25 8:50 AM, David Lechner wrote:
>> On 5/8/25 4:16 AM, Angelo Dureghello wrote:
>>> Hi all,
>>> On 07.05.2025 07:14, Nuno Sá wrote:
>>>> On Tue, 2025-05-06 at 23:03 +0200, Angelo Dureghello wrote:
>>>>> From: Angelo Dureghello <adureghello@baylibre.com>
>>>>>
> 
> ...
> 
>>>>> +		ret = fwnode_property_read_u32(child, "reg", &reg);
>>>>> +		if (ret)
>>>>> +			return ret;
>>>>> +
>>>>> +		/* channel number (here) is from 1 to num_channels */
>>>>> +		if (reg < 1 || reg > num_channels) {
>>>>> +			dev_warn(dev, "wrong ch number (ignoring): %d\n", reg);
>>>>> +			continue;
>>>>> +		}
>>>>> +
>>>>
>>>> Sorry Angelo, just realized this now. Any reason for not treating the above as a real
>>>> invalid argument? It's minor and not a big deal but odd enough...
>>>>
> Ah, I see what you fixed now in v4. All is OK.
> 


Oops, trimmed too much, that was in reply to my own comment not Nuno's.

>> Why is this not correct? Each input could have an amplifier with different
>> series resistor value so this seems correct to me.