From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <mranostay@gmail.com>, Yong Li <sdliyong@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
fengguang.wu@intel.com, Slawomir Stepien <sst@poczta.fm>,
dan.carpenter@oracle.com,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: light apds9960: Add the missing dev.parent
Date: Sat, 14 May 2016 18:50:32 +0100 [thread overview]
Message-ID: <d37ae36a-25cb-bca9-ed5f-588013085ea8@kernel.org> (raw)
In-Reply-To: <CAKzfze-JO0+D9NW8q-JS=v+=7jnMp-rYsZXk3hD28PXvX_D5mw@mail.gmail.com>
On 05/05/16 09:18, Matt Ranostay wrote:
> Reviewed-By: Matt Ranostay <mranostay@gmail.com>
>
> On Thu, May 5, 2016 at 1:10 AM, Yong Li <sdliyong@gmail.com> wrote:
>> Without this, the iio:deviceX is missing in the /sys/bus/i2c/devices/0-0039
>>
>> Signed-off-by: Yong Li <sdliyong@gmail.com>
Applied and marked for stable.
I'd added a brief note that some userspace code may expect this path to work
to justify the stable tag.
Thanks,
Jonathan
>> ---
>> drivers/iio/light/apds9960.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
>> index 35928fb..f47cc0a 100644
>> --- a/drivers/iio/light/apds9960.c
>> +++ b/drivers/iio/light/apds9960.c
>> @@ -1010,6 +1010,7 @@ static int apds9960_probe(struct i2c_client *client,
>>
>> iio_device_attach_buffer(indio_dev, buffer);
>>
>> + indio_dev->dev.parent = &client->dev;
>> indio_dev->info = &apds9960_info;
>> indio_dev->name = APDS9960_DRV_NAME;
>> indio_dev->channels = apds9960_channels;
>> --
>> 2.5.0
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2016-05-14 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 8:10 [PATCH] iio: light apds9960: Add the missing dev.parent Yong Li
2016-05-05 8:18 ` Matt Ranostay
2016-05-14 17:50 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d37ae36a-25cb-bca9-ed5f-588013085ea8@kernel.org \
--to=jic23@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=fengguang.wu@intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mranostay@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=sdliyong@gmail.com \
--cc=sst@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox