From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 1/3] iio: st_sensors: Init trigger before irq request To: Linus Walleij References: <3d90f889782a9c8380c3694e55a135ddd6de9bc4.1463164919.git.leonard.crestez@intel.com> Cc: Jonathan Cameron , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Daniel Baluta , Giuseppe Barba , Denis Ciocca From: Crestez Dan Leonard Message-ID: Date: Tue, 24 May 2016 15:33:45 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 List-ID: On 05/24/2016 02:27 PM, Linus Walleij wrote: > On Fri, May 13, 2016 at 8:43 PM, Crestez Dan Leonard > wrote: > >> This fixes a possible race where an interrupt arrives before complete >> initialization and crashes because iio_trigger_get_drvdata returns NULL. >> >> Cc: Linus Walleij >> Cc: Giuseppe Barba >> Cc: Denis Ciocca >> Signed-off-by: Crestez Dan Leonard >> --- >> I ran into this while breaking the driver. But since the interrupt line can be >> shared the handler should always be able to accept and ignore a call. > > Reviewed-by: Linus Walleij > > However I think my patch fixing the thread issue will collide > by being close in context to this so it'd be great if you > could resend it on top of > "iio: st_sensors: switch to a threaded interrupt"? I checked my local git tree and this was already on top of v6 of that patch. I think this issue is much less likely to cause problems without it. Perhaps it should be incorporated into your patch? I'll resend if it causes conflicts for Jonathan. -- Regards, Leonard