From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA07416E873 for ; Fri, 30 Aug 2024 08:21:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725006066; cv=none; b=Zba/fLoPGvwREK1/f0nui+dbqU8f76ogSkkDCqSBqfL3KC/stPTJELZgJD52Jyinu0incyYcPtr829Bs/Z99siUd20M9dY/OkJyXc2ip+62HbaaHKJEyCASMOl4x/+um/QNJf3YZ6XX8MEQYBv7opeF34HTqGUxUGtG6y64VpdA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725006066; c=relaxed/simple; bh=ZRrIO8FFongovy/jVvUNN9ikqIV8FmbidWhz7Y8mv9A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TFjvVtAuaflXaB8f1nHeVRDvryoVyZOoO3gh8natPsQKkItGbOGz5TgKzh/7UAC4+qpzyUpeELEH3/J4rfW6c0zumFnLWk3kL0UzAtI5pdCw0yTYW8dUNofVQjaN6HWYMf3G+oKBVUj8TIqaP86F1rv2Et4fRZZ5YWLu7pKNSpQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=sh0TCq3e; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="sh0TCq3e" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-371936541caso969668f8f.0 for ; Fri, 30 Aug 2024 01:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1725006063; x=1725610863; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=q4XicNaRrVJUPv9EcovABTtv3epFEIbLpeWnGc571V4=; b=sh0TCq3e59wD4YdbW3ikGNeCdGGBk5EvQRsb/utF50ROgFPA02aB45LGPY8E69o+SA tnOS/qgHnxX9qXlSDCKo35yfhScT9ATYXeCkPuFUML5a/7qZXeOxJV72BtSgQc9POvaP c8/5Piy/4ZwFWgFn3IbuSzv+GNtBj8dfhZkaWKuh8XI3Wf3As1NMWjP/sEVQiPoKuO5H RFZC0LJL5bgzvo1KKyc8Mb67ftCa/TFOPVNMQbJRvIbJK6Vq79iFk2PYgI1R9pBHfQni LhsyKZdClBD3MXdHbuQ5Rmz/ZF+STNfaevSIYPAMn1VVGBp5dF0M0lmC5gC3+xSiAcvg YK+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725006063; x=1725610863; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q4XicNaRrVJUPv9EcovABTtv3epFEIbLpeWnGc571V4=; b=wkb7O3iMreF7QSLm99BSumZ9Aid5U4r3KevUuHBIJZJlZqD9kur4CIhb/kbMehgx/P lj2OR767dgP5K/XWVH7q2PrRiJ1uUSX7uz9zPhXE1N7VqTGC5ApIUb7Yeelfiqj9hXd7 zqGVS6OwYKnzT6T0M1hAfRaStbrSz8eLWnC+Maix0vnEMtxx2Ss3o44tiV06d03YhfCW Xy+hSWxRml8CcyvOYd3hy2ZsY0Au9ntqVK0cVTjAi/PnHROfSBF6NrXYS5azlG0Zbv+6 uMaIt1ZaSqAV/pC49gEbyPzy0t6GZWfUL1InSZYB8XQ3bOcBedJdK5uOQn4gitPWaqEG 6pSw== X-Forwarded-Encrypted: i=1; AJvYcCW4IWD2QBsAyvfzCH4Jk/6zlvXOdnUlbatvTotvC/P0JZx1a0T0Id/2c4huXcqh9msIjlxDCmd/9+g=@vger.kernel.org X-Gm-Message-State: AOJu0YzuE5J6IsHn0NTyL8l3O/BB2cY2eLmDETpNL8fjWTOcEkrJRhWL icdcYaKT6bX6QIiuJsQgbh/p9K1OV7przm6UWSYxwctQMU+wAru6qCaKtCm0PRM= X-Google-Smtp-Source: AGHT+IHsKdHhmas+bCgeJOk3kUQy8TBWC/ztlOmJCXKc1fthdV2EHWysxCPv4TJMDrnZQkt6u+unYQ== X-Received: by 2002:adf:e54c:0:b0:374:b685:676 with SMTP id ffacd0b85a97d-374b6850784mr213801f8f.27.1725006062804; Fri, 30 Aug 2024 01:21:02 -0700 (PDT) Received: from [192.168.0.2] (host-95-233-232-76.retail.telecomitalia.it. [95.233.232.76]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-374b5e3511dsm342234f8f.34.2024.08.30.01.21.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Aug 2024 01:21:02 -0700 (PDT) Message-ID: Date: Fri, 30 Aug 2024 10:19:49 +0200 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 4/8] dt-bindings: iio: dac: add adi axi-dac bus property To: Conor Dooley Cc: Lars-Peter Clausen , Michael Hennerich , =?UTF-8?Q?Nuno_S=C3=A1?= , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Olivier Moysan , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dlechner@baylibre.com References: <20240829-wip-bl-ad3552r-axi-v0-v1-0-b6da6015327a@baylibre.com> <20240829-wip-bl-ad3552r-axi-v0-v1-4-b6da6015327a@baylibre.com> <20240829-stopwatch-morality-a933abb4d688@spud> Content-Language: en-US From: Angelo Dureghello In-Reply-To: <20240829-stopwatch-morality-a933abb4d688@spud> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Conor, On 29/08/24 5:46 PM, Conor Dooley wrote: > On Thu, Aug 29, 2024 at 02:32:02PM +0200, Angelo Dureghello wrote: >> From: Angelo Dureghello >> >> Add bus property. > RFC it may be, but you do need to explain what this bus-type actually > describes for commenting on the suitability of the method to be > meaningful. thanks for the feedbacks, a "bus" is intended as a generic interface connected to the target, may be used from a custom IP (fpga) to communicate with the target device (by read/write(reg and value)) using a special custom interface. The bus could also be physically the same of some well-known existing interfaces (as parallel, lvds or other uncommon interfaces), but using an uncommon/custom protocol over it. In concrete, actually bus-type is added to the backend since the ad3552r DAC chip can be connected (for maximum speed) by a 5 lanes DDR parallel bus (interface that i named QSPI, but it's not exactly a QSPI as a protocol), so it's a device-specific interface. With additions in this patchset, other frontends, of course not only DACs, will be able to add specific busses and read/wrtie to the bus as needed. >> Signed-off-by: Angelo Dureghello >> --- >> Documentation/devicetree/bindings/iio/dac/adi,axi-dac.yaml | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,axi-dac.yaml b/Documentation/devicetree/bindings/iio/dac/adi,axi-dac.yaml >> index a55e9bfc66d7..a7ce72e1cd81 100644 >> --- a/Documentation/devicetree/bindings/iio/dac/adi,axi-dac.yaml >> +++ b/Documentation/devicetree/bindings/iio/dac/adi,axi-dac.yaml >> @@ -38,6 +38,15 @@ properties: >> clocks: >> maxItems: 1 > You mentioned about new compatible strings, does the one currently > listed in this binding support both bus types? > > Making the bus type decision based on compatible only really makes sense > if they're different versions of the IP, but not if they're different > configuration options for a given version. > >> + bus-type: DAC IP on fpga actually respects same structure and register set, except for a named "custom" register that may use specific bitfields depending on the application of the IP. > If, as you mentioned, there are multiple bus types, a non-flag property > does make sense. However, I am really not keen on these "forced" numerical > properties at all, I'd much rather see strings used here. ack, thanks. > Thanks, > Conor. thanks a lot, regards, Angelo >> + maxItems: 1 >> + description: | >> + Configure bus type: >> + - 0: none >> + - 1: qspi >> + enum: [0, 1] >> + default: 0 >> + >> '#io-backend-cells': >> const: 0 >> >> >> -- >> 2.45.0.rc1 >> -- ,,, Angelo Dureghello :: :. BayLibre -runtime team- Developer :`___: `____: