From: Marek Vasut <marek.vasut@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh@kernel.org>,
linux-iio@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms+renesas@verge.net.au>,
Jonathan Cameron <jic23@kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] iio: adc: Add Renesas GyroADC bindings
Date: Tue, 24 Jan 2017 00:15:30 +0100 [thread overview]
Message-ID: <d4fc63bf-c455-2ac4-15d2-6f240799d3e9@gmail.com> (raw)
In-Reply-To: <CAMuHMdUVwQoqQbrsGtbvxK9PoHae3n=UuJYijTMToUsdc=8=mQ@mail.gmail.com>
On 01/23/2017 09:41 PM, Geert Uytterhoeven wrote:
> Hi Marek,
>
> On Mon, Jan 23, 2017 at 8:56 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
>> On 01/23/2017 06:08 PM, Rob Herring wrote:
>>> On Sat, Jan 21, 2017 at 03:42:11PM +0100, Marek Vasut wrote:
>>>> new file mode 100644
>>>> index 000000000000..081947367135
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt
>
>>>> +Required properties:
>>>> +- compatible: Should be "renesas,<chip>-gyroadc", "renesas,rcar-gyroadc".
>>>
>>> Need to enumerate <chip>.
>>
>> It's enumerated below , the only special-case we handle at this point is
>> the r8a7792 , which has extra interrupt block which we don't use anyway,
>> but the driver disables those interrupts.
>
> It is not enumerated below. You just give an example for r8a7791.
>
> Please list all supported/tested compatible values, so checkpatch
> can validate compatible values in DTS patches adding GyroADC device
> nodes.
What about this ?
- compatible: Should be "renesas,<chip>-gyroadc", "renesas,rcar-gyroadc".
The <chip> can be either of:
r8a7791 - for the GyroADC block present in r8a7791 SoC
r8a7792 - for the GyroADC with interrupt block present
in r8a7792 SoC
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2017-01-23 23:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-21 14:42 [PATCH 1/2] iio: adc: Add Renesas GyroADC bindings Marek Vasut
2017-01-21 14:42 ` [PATCH V7 2/2] iio: adc: Add Renesas GyroADC driver Marek Vasut
2017-01-23 17:08 ` [PATCH 1/2] iio: adc: Add Renesas GyroADC bindings Rob Herring
2017-01-23 19:56 ` Marek Vasut
2017-01-23 20:41 ` Geert Uytterhoeven
2017-01-23 23:15 ` Marek Vasut [this message]
2017-01-24 7:30 ` Geert Uytterhoeven
2017-01-24 16:39 ` Marek Vasut
2017-01-24 18:19 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2017-01-27 23:08 Marek Vasut
2017-01-28 11:36 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4fc63bf-c455-2ac4-15d2-6f240799d3e9@gmail.com \
--to=marek.vasut@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).