From: Dan Carpenter <dan.carpenter@linaro.org>
To: Amit Dhingra <mechanicalamit@gmail.com>
Cc: Marcelo Schmitt <marcelo.schmitt@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: correct file entry for AD7091R
Date: Mon, 8 Jan 2024 10:56:02 +0300 [thread overview]
Message-ID: <d537ca6c-180c-4f35-8441-adea03095689@moroto.mountain> (raw)
In-Reply-To: <CAO=gReEUr4B+E2mQsSrncHf41f0A915SuoWgA522_2Ts-dZbSg@mail.gmail.com>
On Sat, Jan 06, 2024 at 12:08:35PM -0800, Amit Dhingra wrote:
> File entry has driver/iio/adc two times. Fix the file entry
>
> Found by ./scripts/get_maintainer.pl --self-test=patterns
>
> Signed-off-by: Amit Dhingra <mechanicalamit@gmail.com>
> ---
> Patch based on jic23/iio.git:togreg branch
>
> I don't think fixes applies here since its not in the mainline yet.
>
Generally, patches to MAINTAINERS don't need Fixes tags.
It doesn't matter if the patch is in mainline or not. If it's in a tree
which is rebased then maintainers will fold the fix into the original
commit and the Fixes tag will be lost. But that's fine.
Also when you're using a Fixes tag, it should all go one one line.
Don't line wrap it at 75 characters. Just go over the limit. That's
the normal/correct way.
regards,
dan carpenter
next prev parent reply other threads:[~2024-01-08 7:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 20:08 [PATCH] MAINTAINERS: correct file entry for AD7091R Amit Dhingra
2024-01-08 7:56 ` Dan Carpenter [this message]
2024-01-08 21:15 ` Amit Dhingra
2024-01-08 21:21 ` Christophe JAILLET
2024-01-08 21:26 ` Amit Dhingra
2024-01-12 1:09 ` Marcelo Schmitt
2024-01-13 15:23 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d537ca6c-180c-4f35-8441-adea03095689@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=mechanicalamit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox