Linux IIO development
 help / color / mirror / Atom feed
From: Potin Lai <potin.lai.pt@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Patrick Williams <patrick@stwcx.xyz>,
	Potin Lai <potin.lai@quantatw.com>,
	linux-iio <linux-iio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/2] iio: humidity: hdc100x: switch to probe_new callback
Date: Fri, 29 Jul 2022 08:43:24 +0800	[thread overview]
Message-ID: <d5f6a7e0-60e7-5afe-30c7-8ba76ab12a5c@gmail.com> (raw)
In-Reply-To: <CAHp75Vf+4Ew2eaccPb3sQY4wAjjsqR7o_uyTUb7eguY=JeDtQA@mail.gmail.com>

On 7/29/22 04:41, Andy Shevchenko wrote:
> On Thu, Jul 28, 2022 at 3:32 PM Potin Lai <potin.lai.pt@gmail.com> wrote:
>> Switch to probe_new callback due to probe is deprecated soon.
> Just noticed that commit message is a bit not okay in a few ways:
> 1) we refer to the callbacks like ->probe_new();
> 2) we don't know when we deprecate it, the point here is not that, but
> unused id parameter in the current code.
>
>
Thanks for point it out, is it OK leave the message as it is? or you prefer to submit another version to fix it?
If new version required, I will also add another patch for struct device pointer you mentioned in the other reply.

Just want to confirm that is the new message looks OK?
New message:
Switch ->porbe() to new callback ->probe_new()

Thanks,
Potin




  reply	other threads:[~2022-07-29  0:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28 12:54 [PATCH v5 0/2] iio: humidity: hdc100x: add manufacturer and device ID check Potin Lai
2022-07-28 12:54 ` [PATCH v5 1/2] iio: humidity: hdc100x: switch to probe_new callback Potin Lai
2022-07-28 20:41   ` Andy Shevchenko
2022-07-29  0:43     ` Potin Lai [this message]
2022-07-29 18:00       ` Andy Shevchenko
2022-07-28 12:54 ` [PATCH v5 2/2] iio: humidity: hdc100x: add manufacturer and device ID check Potin Lai
2022-07-28 20:42   ` Andy Shevchenko
2022-07-31 12:09   ` Jonathan Cameron
2022-08-01  1:50     ` Potin Lai
2022-08-01  8:22       ` Andy Shevchenko
2022-08-01 16:12         ` Patrick Williams
2022-08-01 16:26           ` Andy Shevchenko
2022-08-01 16:30             ` Andy Shevchenko
2022-08-06 17:12               ` Jonathan Cameron
2022-08-08  9:40                 ` Krzysztof Kozlowski
2022-08-08  9:49                   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5f6a7e0-60e7-5afe-30c7-8ba76ab12a5c@gmail.com \
    --to=potin.lai.pt@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrick@stwcx.xyz \
    --cc=potin.lai@quantatw.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox