From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D43B9C352A3 for ; Thu, 6 Feb 2020 14:51:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AAA1E20838 for ; Thu, 6 Feb 2020 14:51:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SF7ZwWqm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727797AbgBFOvh (ORCPT ); Thu, 6 Feb 2020 09:51:37 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:33628 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727864AbgBFOvg (ORCPT ); Thu, 6 Feb 2020 09:51:36 -0500 Received: by mail-lj1-f195.google.com with SMTP id y6so6442603lji.0 for ; Thu, 06 Feb 2020 06:51:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=I0ht39g3wz0a7Uiv+x3fzJJ+to99KRkz7b3na5152wo=; b=SF7ZwWqm6Id+TbMRneD/XkThx+5ujrqg4uF9DGDsuNzT+3BXHANYn9aF8a576zXW2H PQ4f9CVjNmQM5lgdsQRUhwVn7s6LEMeC1VgkbeJa05HZslUwVaDqvINOBqaGYz54cBIM joJUJxBcZZxucVpNkX9lLJ7Uvt/AvIMNv0Wm5X0AQ8gNxzyeb+ubYgkCEinKGWYAeyQX yInk224WWtClDPZkVop9O/K4z9lDcFsM6eQBYdmSYKKpAfFj2+rUm+6pR1sxjW9ta4H+ 0E9igV84RpOBUryHBB9WJYECIdw+JXbo+bVDFSMxBf7lz8LfwDQppXAQmffjdE60yEfb 2beA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=I0ht39g3wz0a7Uiv+x3fzJJ+to99KRkz7b3na5152wo=; b=GS19VeSk3SqI9OQec8395h3F3PTUqnQxP4klKMWsjI4Lhyb8HEVN8R9E437PwnOYYy RBLjONUvMXwe52HjZv7+ZcbL62UPBvCZXP3pM26JzJwO6adfxd1jpQrX7FhQKkXBZfBB ZFVlUCsPEDcZE4KSRuIr//OYwC4fpwNlew1YW0c54RlDtX/X/sw2wLUuEQJxcdOvRQyK 64N9YmZDMS042kkg3Os7E2Dg8riCCo0oZu+eMIt8QUgrD40Ccj/o+59m3eg5yFtOWZod 81bNw+972vIEAB9McIVCc3tlCmZs88gKVyp/YlnnkXtHKpcJ8EWe78GsPNVTYCLEUqd2 aWTw== X-Gm-Message-State: APjAAAXeMeMhA5vf/32/ihx57N3mMm6fu+xhsWOaIjAFINKDrqs7Icp+ Y0Kv5rRjxzGNj2UYps4WBJ3meigc X-Google-Smtp-Source: APXvYqxW+v9V3fAi6PZ5UbICUgL/BQTJ04yW1rlL1VWOE4oHCK7mKQV8EDmx3limhaQ72JZImFmGkQ== X-Received: by 2002:a2e:818e:: with SMTP id e14mr2279139ljg.2.1581000693420; Thu, 06 Feb 2020 06:51:33 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id u16sm1498385ljo.22.2020.02.06.06.51.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Feb 2020 06:51:32 -0800 (PST) Subject: Re: [PATCH v4 3/7] iio: light: al3320a slightly improve code formatting From: Dmitry Osipenko To: David Heidelberg , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Daniel Baluta , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland Cc: linux-iio@vger.kernel.org References: <20200204093031.616409-1-david@ixit.cz> <20200204093031.616409-4-david@ixit.cz> <791299ad-c8e0-a94a-7dbb-780473c8346c@gmail.com> Message-ID: Date: Thu, 6 Feb 2020 17:51:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <791299ad-c8e0-a94a-7dbb-780473c8346c@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org 06.02.2020 17:50, Dmitry Osipenko пишет: > 04.02.2020 12:30, David Heidelberg пишет: > ... >> #define AL3320A_CONFIG_DISABLE 0x00 >> #define AL3320A_CONFIG_ENABLE 0x01 >> >> -#define AL3320A_GAIN_SHIFT 1 >> -#define AL3320A_GAIN_MASK (BIT(2) | BIT(1)) >> +#define AL3320A_GAIN_MASK GENMASK(2, 1) > > Looks like you forgot to compile-test this driver because the > AL3320A_GAIN_SHIFT is removed above, while it's still in-use below. > >> /* chip params default values */ >> #define AL3320A_DEFAULT_MEAN_TIME 4 >> @@ -90,7 +89,8 @@ static int al3320a_init(struct al3320a_data *data) >> return ret; >> >> ret = i2c_smbus_write_byte_data(data->client, AL3320A_REG_CONFIG_RANGE, >> - AL3320A_RANGE_3 << AL3320A_GAIN_SHIFT); >> + FIELD_PREP(AL3320A_GAIN_MASK, >> + AL3320A_RANGE_3)); > ... > Ah, my bad! Sorry :)