Linux IIO development
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>,
	Jonathan Cameron <jic23@kernel.org>
Cc: kernel@axis.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: trigger: sysfs: fix use-after-free on remove
Date: Thu, 19 May 2022 11:58:03 +0200	[thread overview]
Message-ID: <d777d12c-7fd2-07d8-60ee-d2dc8f73f6c7@metafoo.de> (raw)
In-Reply-To: <20220519091925.1053897-1-vincent.whitchurch@axis.com>

On 5/19/22 11:19, Vincent Whitchurch wrote:
> [...]
>   
>
> Fixes: e64e7d5c8c86e ("iio:trigger:sysfs Move out of staging.")
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>

Thanks for the patch!

Strictly speaking the Fixes: should be

f38bc926d022 ("staging:iio:sysfs-trigger: Use irq_work to properly 
active trigger")


Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>

> ---
>   drivers/iio/trigger/iio-trig-sysfs.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/trigger/iio-trig-sysfs.c b/drivers/iio/trigger/iio-trig-sysfs.c
> index 2a4b75897910..3d911c24b265 100644
> --- a/drivers/iio/trigger/iio-trig-sysfs.c
> +++ b/drivers/iio/trigger/iio-trig-sysfs.c
> @@ -191,6 +191,7 @@ static int iio_sysfs_trigger_remove(int id)
>   	}
>   
>   	iio_trigger_unregister(t->trig);
> +	irq_work_sync(&t->work);
>   	iio_trigger_free(t->trig);
>   
>   	list_del(&t->l);



  reply	other threads:[~2022-05-19  9:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19  9:19 [PATCH] iio: trigger: sysfs: fix use-after-free on remove Vincent Whitchurch
2022-05-19  9:58 ` Lars-Peter Clausen [this message]
2022-05-22 11:04   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d777d12c-7fd2-07d8-60ee-d2dc8f73f6c7@metafoo.de \
    --to=lars@metafoo.de \
    --cc=jic23@kernel.org \
    --cc=kernel@axis.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vincent.whitchurch@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox