From: Trevor Gamblin <tgamblin@baylibre.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] iio: adc: ad4695: make ad4695_exit_conversion_mode() more robust
Date: Sun, 19 Jan 2025 21:46:25 -0500 [thread overview]
Message-ID: <d87f1f77-4c8b-4c49-a211-99f06ba94425@baylibre.com> (raw)
In-Reply-To: <20250118171236.782bcb0b@jic23-huawei>
On 2025-01-18 12:12, Jonathan Cameron wrote:
> On Wed, 13 Nov 2024 15:52:59 -0500
> Trevor Gamblin <tgamblin@baylibre.com> wrote:
>
>> Ensure that conversion mode is successfully exited when the command is
>> issued by adding an extra transfer beforehand, matching the minimum CNV
>> high and low times from the AD4695 datasheet. The AD4695 has a quirk
>> where the exit command only works during a conversion, so guarantee this
>> happens by triggering a conversion in ad4695_exit_conversion_mode().
>> Then make this even more robust by ensuring that the exit command is run
>> at AD4695_REG_ACCESS_SCLK_HZ rather than the bus maximum.
>>
>> Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
> Applied 2 and 3 to the testing branch of iio.git.
> I'll be rebasing that on rc1 once available.
>
> Thanks,
>
> Jonathan
Thank you!
next prev parent reply other threads:[~2025-01-20 2:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 20:52 [PATCH v2 0/3] iio: adc: ad4695: add new regmap callbacks, timing improvements Trevor Gamblin
2024-11-13 20:52 ` [PATCH v2 1/3] iio: adc: ad4695: fix buffered read, single sample timings Trevor Gamblin
2024-11-24 12:52 ` Jonathan Cameron
2024-11-25 20:32 ` Trevor Gamblin
2024-11-13 20:52 ` [PATCH v2 2/3] iio: adc: ad4695: make ad4695_exit_conversion_mode() more robust Trevor Gamblin
2025-01-18 17:12 ` Jonathan Cameron
2025-01-20 2:46 ` Trevor Gamblin [this message]
2024-11-13 20:53 ` [PATCH v2 3/3] iio: adc: ad4695: add custom regmap bus callbacks Trevor Gamblin
2024-11-13 20:58 ` [PATCH v2 0/3] iio: adc: ad4695: add new regmap callbacks, timing improvements David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d87f1f77-4c8b-4c49-a211-99f06ba94425@baylibre.com \
--to=tgamblin@baylibre.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox