From: Nathan Chancellor <nathan@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Andreas Brauchli <andreas.brauchli@sensirion.com>
Subject: Re: [PATCH 4/4] iio: chemical: sgp30: Drop use of %hx in format string.
Date: Mon, 17 May 2021 10:13:19 -0700 [thread overview]
Message-ID: <d8f92d79-799e-3533-e075-ed92fec80c84@kernel.org> (raw)
In-Reply-To: <20210517125554.1463156-5-jic23@kernel.org>
On 5/17/2021 5:55 AM, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Since:
> commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
> unnecessary %h[xudi] and %hh[xudi]")
> use of these format strings has been discouraged.
>
> As there are only a few such uses in IIO, lets clear them all out and
> avoid chance of them getting copied into new drivers.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: Andreas Brauchli <andreas.brauchli@sensirion.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/iio/chemical/sgp30.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/chemical/sgp30.c b/drivers/iio/chemical/sgp30.c
> index 1029c457be15..2343d444604d 100644
> --- a/drivers/iio/chemical/sgp30.c
> +++ b/drivers/iio/chemical/sgp30.c
> @@ -425,7 +425,7 @@ static int sgp_check_compat(struct sgp_data *data,
>
> product = SGP_VERS_PRODUCT(data);
> if (product != product_id) {
> - dev_err(dev, "sensor reports a different product: 0x%04hx\n",
> + dev_err(dev, "sensor reports a different product: 0x%04x\n",
> product);
> return -ENODEV;
> }
>
next prev parent reply other threads:[~2021-05-17 17:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 12:55 [RESEND PATCH 0/4] iio: Drop use of %hhx and %hx format strings Jonathan Cameron
2021-05-17 12:55 ` [PATCH 1/4] iio: imu: inv_mpu6050: Drop use of %hhx format string Jonathan Cameron
2021-05-17 17:00 ` Nathan Chancellor
2021-05-17 12:55 ` [PATCH 2/4] iio: light: si1133: Drop remaining uses " Jonathan Cameron
2021-05-17 17:12 ` Nathan Chancellor
2021-05-17 12:55 ` [PATCH 3/4] iio: light: si1145: Drop use of %hhx format specifier Jonathan Cameron
2021-05-17 17:12 ` Nathan Chancellor
2021-05-17 12:55 ` [PATCH 4/4] iio: chemical: sgp30: Drop use of %hx in format string Jonathan Cameron
2021-05-17 17:13 ` Nathan Chancellor [this message]
2021-05-22 18:20 ` [RESEND PATCH 0/4] iio: Drop use of %hhx and %hx format strings Jonathan Cameron
2021-06-03 18:08 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8f92d79-799e-3533-e075-ed92fec80c84@kernel.org \
--to=nathan@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=andreas.brauchli@sensirion.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox