Linux IIO development
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: "Chindris, Mihail" <Mihail.Chindris@analog.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"broonie@kernel.org" <broonie@kernel.org>
Cc: "Hennerich, Michael" <Michael.Hennerich@analog.com>,
	"jic23@kernel.org" <jic23@kernel.org>,
	"Sa, Nuno" <Nuno.Sa@analog.com>,
	"Bogdan, Dragos" <Dragos.Bogdan@analog.com>
Subject: Re: [PATCH v5 1/2] dt-bindings: iio: dac: Add adi,ad3552r.yaml
Date: Mon, 8 Nov 2021 09:32:08 +0100	[thread overview]
Message-ID: <d8fa67fd-5954-efb0-b57c-0f9356f1fe1f@metafoo.de> (raw)
In-Reply-To: <SN4PR03MB679988CBFA34DF338C85549699919@SN4PR03MB6799.namprd03.prod.outlook.com>

On 11/8/21 9:29 AM, Chindris, Mihail wrote:
> ...
>> +patternProperties:
>> +  "^channel@([0-1])$":
>> +    type: object
>> +    description: Configurations of the DAC Channels
>> +    properties:
>> +      reg:
>> +          description: Channel number
>> +          enum: [0, 1]
>> +
>> +      custom-output-range-config:
> Copy unanswered comment from V3
>
>>>> Not a generic property so I think this needs an adi prefix.
>>>> Jonathan
>>> I tried with adi prefix but I get weird errors while running dt_binding_check for properties with adi prefix and with type:object
>>> Do you have any suggestion for this issues?
>>>
>>> Mihail
>>>
> @Rob
> Jonathan

I had the same problem with the bindings for the xadc driver: 
https://www.spinics.net/lists/devicetree/msg382081.html


>> +        type: object
>> +        description: Configuration of custom range when
>> +          adi,output-range-microvolt is not present.
>> +          The formulas for calculation the output voltages are
>> +            Vout_fs = 2.5 + [(GainN + Offset/1024) * 2.5 * Rfbx * 1.03]
>> +            Vout_zs = 2.5 - [(GainP + Offset/1024) * 2.5 * Rfbx * 1.03]
> ...



  reply	other threads:[~2021-11-08  8:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08  8:24 [PATCH v5 0/2] drivers:iio:dac: Add AD3552R driver support Mihail Chindris
2021-11-08  8:24 ` [PATCH v5 1/2] dt-bindings: iio: dac: Add adi,ad3552r.yaml Mihail Chindris
2021-11-08  8:29   ` Chindris, Mihail
2021-11-08  8:32     ` Lars-Peter Clausen [this message]
2021-11-08  8:24 ` [PATCH v5 2/2] drivers:iio:dac: Add AD3552R driver support Mihail Chindris
2021-11-14 13:07   ` Jonathan Cameron
2021-11-15 11:31     ` Chindris, Mihail

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8fa67fd-5954-efb0-b57c-0f9356f1fe1f@metafoo.de \
    --to=lars@metafoo.de \
    --cc=Dragos.Bogdan@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=Mihail.Chindris@analog.com \
    --cc=Nuno.Sa@analog.com \
    --cc=broonie@kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox