From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11482393DC8 for ; Tue, 17 Mar 2026 08:07:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773734867; cv=none; b=fB8IaWzUbDE6tVnp9CrCNhjN3+xmpK6Filfopo36Cwig+41pKhPjqs5AgdicWEsO3tyCJJGzfSaJ5QEcFVZjNM+Utkn8fnb9NDoKpKrlldqx6i7TsdAjOkX1D5jLsjlUfrQzH8h0hI2iP7eQF/5E4+PYDWiuByicImub/r6InTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773734867; c=relaxed/simple; bh=xjMI3kWLb004RFGciwvvZcxiwmFj4VVzpHoNLJgITKQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V1XzqBWqghxZikiA9MPZb6WlgXWjK4L45YcnL3KU1d7bZfvcPWgVMNh9XRDa8j3R6OXng1AYugwU/waJtr7ucxtTgoaoH2v+FidtdlMPvQ0N2x4PHpiF+NMSwaIa/fjOOxPFoPtAWzwjRPproQC+BmXRR0EDWoWWuD+mOAcMALw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yr/HjY3i; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yr/HjY3i" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-6651702ea48so3823089a12.2 for ; Tue, 17 Mar 2026 01:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773734863; x=1774339663; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zH58nQVPnaeEnUw730ASGfF9l+ejJ6sv9p1FAkERXbs=; b=Yr/HjY3i0z05NXV2n+9u2rLpjSTAQA6C5n5F6bXf5kuhRPunLI+fR5ENlF8X2e/2qY aiE547oHcpobbrStQkqGCvT2OdzmG5jogJYsVCyd356eEWLhVy9wvxlPMOKyeLpJy1JC FKWklfEzrseRM97NkJ8573zCuA4bUaZnokqkXtwOQ+9X6uj3jMM7o5elCcEcSS8pAV2h k/hiqVNqkXSidFLyq4ZgLQYEOfTnnbr2gL2KDmFAFIjh+7zEcrFcJeGQqsW0nqwDZxya H0CGYEBuohgoLOZKwRiJXTRvPewVLChYCHwc/7n/lKI5w+Xq0W+ajSb+K0A/lD/Ntr08 TZIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773734863; x=1774339663; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zH58nQVPnaeEnUw730ASGfF9l+ejJ6sv9p1FAkERXbs=; b=ksU9OV9gXefjKMVcstHMsBDh2HHcMNcs5RCnj5q0i+qsvxUTcIM5YnOrk0SVNWLdCW qr03GL0Gn3ZXFzIizmJ7eezEJyK2JSkFvkv70hYGA7UtNTLERFAGP+Mf8sGx0aRjYDPJ yjDLUd8ElhUxm1rR5u7Ye1p86QW6pW9yWIF94bSkP+YC5hnJaXHVB4ESyrhGaiz1+9wR XrePGS43EVeD7oAZCUx/HH70HHbJ7h0yQCrSZdwH39XvVfdi31/VL5UsqoSE5Of8oGkr 5W0WFoYSioqKK7D+BQ4dnaLbn699yU4kWQNhMN2dab4bb4wdIlZBi+2hK+r/N4RMWS23 UCLg== X-Forwarded-Encrypted: i=1; AJvYcCUn0UkUNPBQLRuEYfnvPWEtyFPIWSv0p/qoYPFDZCU6JRUFRNcMTDs3NTouBuHWJvu2LdhhKkgotzY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1l7VoCDSEQmj4gCC8rU1LF448jd0tnKaL7ZH3MvXioZHqNFYj TfKFQuFbvKQ1G7h/LWEkXWjod9/8a5sggg+scmlYQfsCS+SBOOi1OOvv X-Gm-Gg: ATEYQzzJ7vLjn7tupuasi6PxV2PyeflcmwVptRJf4z7la0OKa16TD0MjQsTHGwkDubt BBZXpOdg6yw11DGqOt03MMq9nsW6QV5hBIi1mjxuP0n9fzV/Kx6Az0Nzm71b0NJ+uSQ/6pgNohT 80hW7Sn3NrVZ9vwhDeCXFjfQMC8Rale8RV02SOW/ftlJMD68fPewTNxQRVtuivzTsFeXgJmkayH Ued+1xYrA7Ke5CEFQhL2zZvCCsBQt8R9+FGWlPxmj0J2La7jVHGFEnEXrHiVKtoS/JUgNnstGFd qhHlefua1TxR39L+vbk+zHFagG0Q7zzNnxKqVsyZduFDwj2uWvn7Zfxhv1nndbPBC9fJE1LzEza 1UKnBMq8B4z0AoZf4B7xYgQm9JDRYSEMzP8SLfCdxNgRU5ZbzfQ9lid3wBJd29VvYfdIM39FqD6 jvwKvZJYiuT3BIwtYrii1wJ6KWfzfLBaAWhofY X-Received: by 2002:a17:907:6d05:b0:b97:b378:62ba with SMTP id a640c23a62f3a-b97b3786658mr484917966b.33.1773734862942; Tue, 17 Mar 2026 01:07:42 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b976cdb47fasm666212966b.43.2026.03.17.01.07.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2026 01:07:42 -0700 (PDT) Message-ID: Date: Tue, 17 Mar 2026 10:07:41 +0200 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/7] dt-bindings: iio: light: vcnl4000: add regulators To: Krzysztof Kozlowski Cc: Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> <20260316-vcnl4000-regulators-v4-1-854fc2eaf54b@gmail.com> <20260317-tricky-pony-of-assurance-7a8cac@quoll> Content-Language: en-US From: Erikas Bitovtas In-Reply-To: <20260317-tricky-pony-of-assurance-7a8cac@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/17/26 9:20 AM, Krzysztof Kozlowski wrote: > On Mon, Mar 16, 2026 at 07:19:45PM +0200, Erikas Bitovtas wrote: >> These sensors can accept 2 supplies - one for the sensor and one for IR >> LED [1]. Add supply properties for the sensor - 2 for the sensors and >> one external, for their I2C bus, to ensure the sensor is powered on >> before proceeding with setup. >> >> [1] https://www.vishay.com/docs/84274/vcnl4040.pdf >> >> Reviewed-by: David Lechner >> Signed-off-by: Erikas Bitovtas >> --- >> Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml >> index 2ba4d5de4ec4..a1b4c02db246 100644 >> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml >> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml >> @@ -33,6 +33,10 @@ properties: >> interrupts: >> maxItems: 1 >> >> + vdd-supply: true >> + vddio-supply: true >> + vled-supply: true > > Same comments as before, I do not see improvements. > > Best regards, > Krzysztof > I explained why in v3. The message can be found here: https://lore.kernel.org/linux-iio/cb92bb47-9078-475d-b242-71e3f9181a72@baylibre.com/T/#m6da277894cf5c2b473fbeebd4b7bafc7519ebc26