Linux IIO development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marcin Bis <marcin@bis-linux.com>, linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: iio: dac: adi,ad5337: add dt-bindings
Date: Sat, 13 Jun 2026 09:48:05 +0200	[thread overview]
Message-ID: <dcfef506-a7e5-473e-899b-07bf3dd546a5@kernel.org> (raw)
In-Reply-To: <20260612133125.196208-2-marcin@bis-linux.com>

On 12/06/2026 15:31, Marcin Bis wrote:
> Add dt-bindings for the AD5337 dual 8-bit I2C voltage-output DAC driver.
> 
> Signed-off-by: Marcin Bis <marcin@bis-linux.com>

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.

Please organize the patch documenting the compatible (DT bindings)
before the patch using that compatible.
See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46

Best regards,
Krzysztof

  parent reply	other threads:[~2026-06-13  7:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-12 13:31 [PATCH 1/2] iio: dac: ad5337: Add driver for the AD5337 DAC Marcin Bis
2026-06-12 13:31 ` [PATCH 2/2] dt-bindings: iio: dac: adi,ad5337: add dt-bindings Marcin Bis
2026-06-12 13:58   ` Joshua Crofts
2026-06-12 17:09   ` Jonathan Cameron
2026-06-13  7:48   ` Krzysztof Kozlowski [this message]
2026-06-12 14:20 ` [PATCH 1/2] iio: dac: ad5337: Add driver for the AD5337 DAC Joshua Crofts
2026-06-12 17:27 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dcfef506-a7e5-473e-899b-07bf3dd546a5@kernel.org \
    --to=krzk@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=marcin@bis-linux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox