From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:48831 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752845AbcEAV0Y (ORCPT ); Sun, 1 May 2016 17:26:24 -0400 Subject: Re: [patch] iio: dac: ad5592r: Off by one bug in ad5592r_alloc_channels() To: Dan Carpenter , Lars-Peter Clausen References: <20160429090330.GB18656@mwanda> Cc: Michael Hennerich , Hartmut Knaack , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org From: Jonathan Cameron Message-ID: Date: Sun, 1 May 2016 20:04:32 +0100 MIME-Version: 1.0 In-Reply-To: <20160429090330.GB18656@mwanda> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 29/04/16 10:03, Dan Carpenter wrote: > The > here should be >= or we go beyond the end for the array. > > Signed-off-by: Dan Carpenter Good spot - marked it to pick up when I am back on the internet soonish.... (though perhaps not when I my computer manages to sneak this lot out!) > > diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-base.c > index 948f600..69bde59 100644 > --- a/drivers/iio/dac/ad5592r-base.c > +++ b/drivers/iio/dac/ad5592r-base.c > @@ -525,7 +525,7 @@ static int ad5592r_alloc_channels(struct ad5592r_state *st) > > device_for_each_child_node(st->dev, child) { > ret = fwnode_property_read_u32(child, "reg", ®); > - if (ret || reg > ARRAY_SIZE(st->channel_modes)) > + if (ret || reg >= ARRAY_SIZE(st->channel_modes)) > continue; > > ret = fwnode_property_read_u32(child, "adi,mode", &tmp); > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >