linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: Matt Ranostay <mranostay@gmail.com>, linux-iio@vger.kernel.org
Cc: jic23@kernel.org
Subject: Re: [RFC v4 2/3] iio: adc: ti-adc161s626: add support for TI 1-channel differential ADCs
Date: Sat, 20 Aug 2016 18:47:43 +0200	[thread overview]
Message-ID: <de1272c8-cf35-84f3-84db-eaa42525a5bc@gmail.com> (raw)
In-Reply-To: <1471663024-25623-3-git-send-email-mranostay@gmail.com>

On 08/20/2016 05:17 AM, Matt Ranostay wrote:
> Add support for Texas Instruments ADC141S626, and ADC161S626 chips.

Hi,

[...]

> +++ b/Documentation/devicetree/bindings/iio/adc/ti-adc161s626.txt
> @@ -0,0 +1,17 @@
> +* Texas Instruments ADC141S626, and ADC161S626 chip

I think you should drop the comma and use plural (chips) here.

> +Required properties:
> + - compatible: Should be "ti,adc141s626" or "ti,adc161s626"
> + - reg: spi chip select number for the device
> +
> +Recommended properties:
> + - spi-max-frequency: Definition as per
> +		Documentation/devicetree/bindings/spi/spi-bus.txt
> +
> +Example:
> +adc@0 {
> +	compatible = "ti,adc161s626";
> +	reg = <0>;
> +	spi-max-frequency = <4300000>;
> +};
> +
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 1de31bdd4ce4..2658f2f69bad 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -426,6 +426,18 @@ config TI_ADC128S052
>  	  This driver can also be built as a module. If so, the module will be
>  	  called ti-adc128s052.
>  
> +config TI_ADC161S626
> +	tristate "Texas Instruments ADC161S626 1-channel differential ADC"
> +	depends on SPI
> +	select IIO_BUFFER
> +	select IIO_TRIGGERED_BUFFER
> +	help
> +	  If you say yes here you get support for Texas Instruments ADC141S626,
> +	  and ADC161S626 chips.
> +
> +	  This driver can also be build

... be built ... :-)

> as a module. If so, the module will be
> +	  called ti-adc161s626.
> +
>  config TI_ADS1015
>  	tristate "Texas Instruments ADS1015 ADC"
>  	depends on I2C && !SENSORS_ADS1015

The code looks OK.

-- 
Best regards,
Marek Vasut

  reply	other threads:[~2016-08-20 16:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-20  3:17 [RFC v4 0/3] iio: potentiostat: add LMP91000 support Matt Ranostay
2016-08-20  3:17 ` [RFC v4 1/3] iio: buffer-callback: allow getting underlying iio_dev Matt Ranostay
2016-08-21 10:47   ` Jonathan Cameron
2016-08-20  3:17 ` [RFC v4 2/3] iio: adc: ti-adc161s626: add support for TI 1-channel differential ADCs Matt Ranostay
2016-08-20 16:47   ` Marek Vasut [this message]
2016-08-21 10:51     ` Jonathan Cameron
2016-08-20  3:17 ` [RFC v4 3/3] iio: potentiostat: add LMP91000 support Matt Ranostay
2016-08-21 10:46   ` Jonathan Cameron
2016-08-26  3:09     ` Matt Ranostay
2016-08-29 17:38       ` Jonathan Cameron
2016-08-30  6:01         ` Matt Ranostay
2016-09-03 14:59           ` Jonathan Cameron
2016-09-04  4:56             ` Matt Ranostay
2016-09-06  1:58               ` Matt Ranostay
2016-09-10 14:18                 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de1272c8-cf35-84f3-84db-eaa42525a5bc@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=mranostay@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).