Re: max1363 : Warnings from iio_sanity_check_avail_scan_masks()

[Matti Vaittinen <mazziesaccount@gmail.com>]

Hi deee Ho peeps!

On 26/04/2025 18:00, Jonathan Cameron wrote:
> On Wed, 23 Apr 2025 17:23:28 -0300
> Fabio Estevam <festevam@gmail.com> wrote:
>> After upgrading the kernel from 6.1 to 6.12 (also tested with
>> linux-next), I started seeing the following warnings on a board
>> populated with a Maxim MAX11601 ADC:
>>
>> [    1.554029] max1363 1-0064: available_scan_mask 8 subset of 0. Never used
>> [    1.563627] max1363 1-0064: available_scan_mask 9 subset of 0. Never used
>>
>> What is the correct way to fix these warnings?
> 
> Ah.  I think we have an order of modes bug.. Later entries should never be a subset
> of earlier ones and we only recently added a sanity check on that.

This indeed rings a bell :) I have nothing really to add to the answers 
by Jonathan, but I just noticed the warning print isn't as clear as it 
could. As far as I understand, the printed values aren't the actual 
masks, but indexes in the mask arrays. Now that I had this stuff 
forgotten, I was puzzled by the print until I read the code.

I believe it'd be more informative if we printed the actual bit masks - 
but I am not sure if we know the size of the mask. If we keep printing 
the indexes, then we might want to add brackets [] to indicate the value 
is an index? How about:

"available_scan_masks: mask[8] subset of mask[0]. Never used"

instead of:
available_scan_mask 8 subset of 0. Never used

Would that be more obvious?

Yours,
	-- Matti