From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 635F91E502 for ; Sun, 10 Mar 2024 20:53:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710103988; cv=none; b=CZ32JOHRbOcQ7LYesX+evosNbyZRBEbtE6cgWn5ES9FyB+/gAy3OlD/GzmyTw7P2mFpCrT2vw+WXgQIZv6bLzAnB4UZUBar2fzDgR/5q3kQowOnNRaKpIsOsjH+P7z1M3NiDafOe60xv6OtIoznlmUp1p8dVcx9eQkoPjtMf2i8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710103988; c=relaxed/simple; bh=frxuvVcUFE3n0LsEt2HQl02eTQPGunwmknVSe8KFctQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NkrfhYMwTZDh+wooQlOjAsuxip6jhm3Jz2LeY8asjjCOg+eQ+NUW3oC//iVFDZQYJGyeQ3heYC/YK5KOoCQBKuMvdGVTCJGyoY4B0XC1WYgIB6dN4jnJsex7/AwmXkK344qpLPROQoUkaAxXi5vww4BzQQnGiTSogy1XNCn87MM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tweaklogic.com; spf=pass smtp.mailfrom=tweaklogic.com; dkim=pass (2048-bit key) header.d=tweaklogic.com header.i=@tweaklogic.com header.b=Nidc7Dnj; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tweaklogic.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tweaklogic.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tweaklogic.com header.i=@tweaklogic.com header.b="Nidc7Dnj" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1dd5df90170so24841025ad.0 for ; Sun, 10 Mar 2024 13:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tweaklogic.com; s=google; t=1710103986; x=1710708786; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9eh/L4jnp3P9JkldJjrWGMupxrpCciyDkMmG2Xv6fIY=; b=Nidc7DnjkYIQGQDmOdHjFdybO4d/tALcw5YKuzRRxmktd1UQriEAnHHGQP0TlPN7TO 7NYofk+gR0/1BZzwXmUXl/YoJh/8FABqLcFx+fxJi44/Z8KyihJR0H5roubiaWkte+iX BI8f4ByApfz8SduC7WKMF57eiQgBzPyt20itbOIlE/tidazUU4wFY0QdmAEO0Zni7dgR 74MtICoGqFRmqq5aGdPFkauORaztmaZqG4Wa8dMOxpOM1THFceuxeOn6aYoa3rwdbPhk /Sgjv22bemKO7jH1c5UhU5/qYnPTvTVS2P30AWsEMfFKLOVFMVGs5xQ2Ai0EHPTPRCCW aLMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710103986; x=1710708786; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9eh/L4jnp3P9JkldJjrWGMupxrpCciyDkMmG2Xv6fIY=; b=pVoKkiDSV7jCr+Vc2Ppfz7I8swTdFI1k3LXz6Mu9XTnBo1DaGvUbtnwplZXVjHCGQl ZoTE7u/wXUSWauynk1qMdE/FfbQg942SRcx10Gb9vcy+ij8ITlZ8242a4nF9lcjXibKG wi6eX1zXnxI2jkXENYW494OYtUyl0ZrSWTXAC1l9l+TV1nNG+Q3Xd19CtQbNdSAYWekQ FSTQqVlsiCMkIKK8ZLwzSRCwxAFt0hSk8UTqdNRZPQtSClvCYhVOLuGA63OhYGdGG7G3 7aJo3V3wInDDIknczeVV91XDTa8wkr3PH6Xu0t5hE7R5Su9Vrg/PpR/wTyJBMC8Zf8QB d2iA== X-Forwarded-Encrypted: i=1; AJvYcCV4zGKRtYJPi+3Y4gxL7L96iz2epjv29sx2ISUt2VOBQxiBc6QCcIoeYYZdIoSOmtADxXyMKPITswWROXJyz9iwxXpPsNXpxwMF X-Gm-Message-State: AOJu0YwRdWAWz4wzu9b4elqCAhzq6DD28kYnMVxyGGMnmkII9kVId52j 8O2xDBfXEqL6FnA4IhB+ZwS9xkA0rSVRbmoboZdIQiQOTDKY2m9d1lbH3xgUVAk= X-Google-Smtp-Source: AGHT+IG8+eAJ1v1PdTnMZSx6KVr2Kimd2P/DvL1NRB9VDSL2T+mhTMgPo+Gibtu01PBp7SDUQ8fjBw== X-Received: by 2002:a17:903:32d2:b0:1dd:619e:aeaf with SMTP id i18-20020a17090332d200b001dd619eaeafmr5571936plr.22.1710103986567; Sun, 10 Mar 2024 13:53:06 -0700 (PDT) Received: from [192.168.20.11] ([180.150.112.31]) by smtp.gmail.com with ESMTPSA id b10-20020a170902650a00b001db6da30331sm3159582plk.86.2024.03.10.13.53.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Mar 2024 13:53:06 -0700 (PDT) Message-ID: Date: Mon, 11 Mar 2024 07:22:58 +1030 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 5/5] iio: light: Add support for APDS9306 Light Sensor To: Jonathan Cameron Cc: Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matti Vaittinen , Andy Shevchenko , Marek Vasut , Anshul Dalal , Javier Carrasco , Matt Ranostay , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240309105031.10313-1-subhajit.ghosh@tweaklogic.com> <20240309105031.10313-6-subhajit.ghosh@tweaklogic.com> <20240310124237.52fa8a56@jic23-huawei> Content-Language: en-US From: Subhajit Ghosh In-Reply-To: <20240310124237.52fa8a56@jic23-huawei> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > >> + >> +static int apds9306_write_event_config(struct iio_dev *indio_dev, >> + const struct iio_chan_spec *chan, >> + enum iio_event_type type, >> + enum iio_event_direction dir, >> + int state) >> +{ >> + struct apds9306_data *data = iio_priv(indio_dev); >> + struct apds9306_regfields *rf = &data->rf; >> + int ret, val; >> + >> + state = !!state; >> + >> + switch (type) { >> + case IIO_EV_TYPE_THRESH: { >> + guard(mutex)(&data->mutex); >> + >> + /* >> + * If interrupt is enabled, the channel is set before enabling >> + * the interrupt. In case of disable, no need to switch >> + * channels. In case of different channel is selected while >> + * interrupt in on, just change the channel. >> + */ >> + if (state) { >> + if (chan->type == IIO_LIGHT) >> + val = 1; >> + else if (chan->type == IIO_INTENSITY) >> + val = 0; >> + else >> + return -EINVAL; >> + >> + ret = regmap_field_write(rf->int_src, val); >> + if (ret) >> + return ret; >> + } >> + >> + ret = regmap_field_read(rf->int_en, &val); >> + if (ret) >> + return ret; >> + >> + if (val == state) >> + return 0; >> + >> + ret = regmap_field_write(rf->int_en, state); >> + if (ret) >> + return ret; >> + >> + if (state) >> + return pm_runtime_resume_and_get(data->dev); >> + >> + pm_runtime_mark_last_busy(data->dev); >> + pm_runtime_put_autosuspend(data->dev); > Note this isn't a reason to do a v10, just a possible suggestion for > what I think is more readable code. > > Flow here is complex, maybe we'd have been better with skipping the > state = !!state, rename val to more explicit enabled > above and something like.. > > ret = regmap_field_read(rf->int_en, &enabled); > if (ret) > return ret; > > if (state) { > if (chan->type == IIO_LIGHT) > ret = regmap_field_write(rf->int_src, 1); > else if (chan->type == IIO_INTENSITY) > ret = regmap_field_write(rf->int_src, 0); > else > return -EINVAL; > > if (ret) > return ret; > if (enabled) /* Already enabled */ > return 0; > > ret = regmap_field_write(rf->int_en, 1); > if (ret) > return ret; > > return pm_runtime_resume_and_get(data->dev); > } else { // Could drop this else but I think it's useful to show the either or flow. > if (!enabled) > return 0; > > ret = regmap_field_write(rf->int_en, 0); > if (ret) > return ret; > pm_runtime_mark_last_busy(data->dev); > pm_runtime_put_autosuspend(data->dev); > > return 0; > } > } Yes, this is much simpler and readable. I will prepare a follow up patch for this. Thank you for reviewing and applying the series. Regards, Subhajit Ghosh >> + >> + return 0; >> + } >> + case IIO_EV_TYPE_THRESH_ADAPTIVE: >> + return regmap_field_write(rf->int_thresh_var_en, state); >> + default: >> + return -EINVAL; >> + } >> +} > >> + >> +static void apds9306_powerdown(void *ptr) >> +{ >> + struct apds9306_data *data = (struct apds9306_data *)ptr; >> + struct apds9306_regfields *rf = &data->rf; >> + int ret; >> + >> + ret = regmap_field_write(rf->int_thresh_var_en, 0); >> + if (ret) >> + return; >> + >> + ret = regmap_field_write(rf->int_en, 0); >> + if (ret) >> + return; >> + >> + apds9306_power_state(data, false); >> +} > > ... >