From: Hans de Goede <hdegoede@redhat.com>
To: Bastien Nocera <hadess@hadess.net>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Jonathan Cameron <jic23@kernel.org>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v2] iio/hid-sensors: Fix IIO_CHAN_INFO_RAW returning wrong values for signed numbers
Date: Tue, 13 Nov 2018 14:34:20 +0100 [thread overview]
Message-ID: <e67ee29a-8451-e9c0-5839-262ce56898e3@redhat.com> (raw)
In-Reply-To: <4990a4a867c57493e5ed525a8df5142281958393.camel@hadess.net>
Hi,
On 13-11-18 14:09, Bastien Nocera wrote:
> On Wed, 2018-10-31 at 15:20 +0100, Hans de Goede wrote:
>> Before this commit sensor_hub_input_attr_get_raw_value() failed to
>> take
>> the signedness of 16 and 8 bit values into account, returning e.g.
>> 65436 instead of -100 for the z-axis reading of an accelerometer.
>
> Anything I need to change in iio-sensor-proxy for this?
No, AFAICT all hid sensors offer the buffered API, so iio-sensor-proxy
will prefer that. This is also likely the cause of why this was not
caught earlier.
Regards,
Hans
prev parent reply other threads:[~2018-11-13 23:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 14:20 [PATCH v2] iio/hid-sensors: Fix IIO_CHAN_INFO_RAW returning wrong values for signed numbers Hans de Goede
2018-10-31 14:21 ` Hans de Goede
2018-11-03 12:26 ` Jonathan Cameron
2018-11-03 15:53 ` Srinivas Pandruvada
2018-11-15 8:20 ` Benjamin Tissoires
2018-11-16 11:43 ` Jonathan Cameron
2018-11-13 13:09 ` Bastien Nocera
2018-11-13 13:34 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e67ee29a-8451-e9c0-5839-262ce56898e3@redhat.com \
--to=hdegoede@redhat.com \
--cc=benjamin.tissoires@redhat.com \
--cc=hadess@hadess.net \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox