From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D293AC10DCE for ; Tue, 24 Mar 2020 21:24:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9916E2070A for ; Tue, 24 Mar 2020 21:24:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lis2lnCS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727088AbgCXVYv (ORCPT ); Tue, 24 Mar 2020 17:24:51 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:46686 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727023AbgCXVYv (ORCPT ); Tue, 24 Mar 2020 17:24:51 -0400 Received: by mail-lj1-f194.google.com with SMTP id v16so220277ljk.13 for ; Tue, 24 Mar 2020 14:24:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=alhh8KqibGsNYsTvIJ0sN0oTbHXSUSos8KQ3Gz6iRzs=; b=lis2lnCS1PTv5DB3Pl44vCMKFgWgUCA+SZb4Su3OGnOmLekH1+dwUr3sA0Cy3l44nk NU9OW0vqGY1Lq/a9L8M47WkArvdmWG72PfGWSvxtMfdbcFaZMZW0SiciABnQSNjS1tgJ Yu+aeNtdaGyGPsnxiadzW2WJJyQ0edmR0H7tE29bBS0m+ZlLZG7z1qRUi8x50T9Tguax zzyA5qBjee0q1/uWqy71Z3q23VEarkhePzFpJXeFRqDI6Z4hm/wK2rIAmyDV2KJQOTsP r/wu6MfcK8Qh1Lm/5ROcy31GMcUMAU6ocjdLLYyB/JKe7MpUSLLZqVNarvjgt+Umb4GL Yn7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=alhh8KqibGsNYsTvIJ0sN0oTbHXSUSos8KQ3Gz6iRzs=; b=IftcEiANmehLK0NK1VN9yUs0Q0TQ5hlyFQDFHPaU6fYg2clYeHmXpcxduxwY0Q+Qcw pu8iJM1zIZqO4u1JSaYwIXEwqKwq8Hr4aZ5tnNAQ38WxTaV4Nw7AqK6hqSY1CB7eBzGt fl8FUh++b9AmELC2PtTn17VJzRhLdFhVmFYRVPqE/3sY7YUnmRq99LnTfZ9AQWS2Ge+d F2MvYEBjZhLUIjOZtKqic2rb3UPkoIohXxPS6iP0CVLg5YhpTsLW7AgvCXqlFIo8YSIZ RiG/UDw/GZxM+AKUSr0eLtTK2CtO3r0fJAl+YYWYQd8l2029LbJUKBHWwIhdFCUDbztV LLiQ== X-Gm-Message-State: ANhLgQ0oTsVjQqRbFlzcTXjg9DkaKJqL3Hjz155IG7knp52SUzmhf6N/ PWvtqLySOXx6FyTjFRYMlSj6sS5q X-Google-Smtp-Source: ADFU+vvD7Sn3kjXKHTZmau3YSMPrb7oJoXoX3/MdxLCaIpc5jc+vuT5FHPT3l+HLFxelYPb97P85pg== X-Received: by 2002:a2e:9284:: with SMTP id d4mr17910676ljh.226.1585085088494; Tue, 24 Mar 2020 14:24:48 -0700 (PDT) Received: from [192.168.2.145] (94-29-39-224.dynamic.spd-mgts.ru. [94.29.39.224]) by smtp.googlemail.com with ESMTPSA id v22sm2953148ljc.79.2020.03.24.14.24.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2020 14:24:48 -0700 (PDT) Subject: Re: [PATCH v2 12/13] iio: imu: inv_mpu6050: use runtime pm with autosuspend To: Jean-Baptiste Maneyrol , jic23@kernel.org, linux-iio@vger.kernel.org References: <20200219143958.3548-1-jmaneyrol@invensense.com> <20200219143958.3548-13-jmaneyrol@invensense.com> From: Dmitry Osipenko Message-ID: Date: Wed, 25 Mar 2020 00:24:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200219143958.3548-13-jmaneyrol@invensense.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org 19.02.2020 17:39, Jean-Baptiste Maneyrol пишет: > Use runtime power management for handling chip power and > sensor engines on/off. Simplifies things a lot since pm > runtime already has reference counter. > Usage of autosuspend reduces the number of power on/off. This > makes polling interface now usable to get data at low > frequency. > > Signed-off-by: Jean-Baptiste Maneyrol > --- > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 267 ++++++++++++------ > drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 5 +- > drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c | 33 ++- > 3 files changed, 194 insertions(+), 111 deletions(-) Hello, This patch introduces a system suspend-resume regressing, I'm seeing the following on entering into suspend: vdd_gen1v8: Underflow of regulator enable count inv-mpu6050-i2c 1-0068: Failed to disable vddio regulator: -22 Apparently RPM disables the regulator and then it's erroneously disabled second time on suspend. Please fix it, thanks in advance.