From: "Nuno Sá" <noname.nuno@gmail.com>
To: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Nuno Sá" <nuno.sa@analog.com>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Drew Fustini <drew@pdp7.com>
Subject: Re: [PATCH 1/2] iio: ltc2983: add support for optional reset gpio
Date: Mon, 23 Aug 2021 14:51:33 +0200 [thread overview]
Message-ID: <e81553af88194c89f6d31bf83e6e486fe75bd4ea.camel@gmail.com> (raw)
In-Reply-To: <CAHp75VdDkXT=6d8HKAgeSH-h8O0ERvsNidwrbnyvGZHD0GjgAQ@mail.gmail.com>
On Mon, 2021-08-23 at 14:14 +0300, Andy Shevchenko wrote:
> On Fri, Aug 20, 2021 at 9:53 AM Nuno Sá <nuno.sa@analog.com> wrote:
> > Check if an optional reset gpio is present and if so, make sure to
> > reset
> > the device.
>
> ...
>
> > + usleep_range(1000, 1005);
>
> The delta should be at least 20%, otherwise I'm not sure why such a
> strict range?
>
No special reason... I just had no hard requirement for delta so I just
gave something small. Is 20% documented anywhere? I did a quick look on
the API's and I could not find nothing related. Anyways, if that is a
best practise for being more power friendly I'm happy to change it...
(well, we might end up just having 100ms here which means 'msleep()').
- Nuno Sá
next prev parent reply other threads:[~2021-08-23 12:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 6:55 [PATCH 1/2] iio: ltc2983: add support for optional reset gpio Nuno Sá
2021-08-20 6:55 ` [PATCH 2/2] iio: ltc2983: fail probe if no channels are given Nuno Sá
2021-08-20 8:22 ` Alexandru Ardelean
2021-08-20 8:21 ` [PATCH 1/2] iio: ltc2983: add support for optional reset gpio Alexandru Ardelean
2021-08-20 9:29 ` Sa, Nuno
2021-08-20 18:58 ` Alexandru Ardelean
2021-08-23 7:04 ` Sa, Nuno
2021-08-25 8:24 ` Sa, Nuno
2021-08-23 11:14 ` Andy Shevchenko
2021-08-23 12:51 ` Nuno Sá [this message]
2021-08-23 14:27 ` Andy Shevchenko
2021-08-23 14:51 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e81553af88194c89f6d31bf83e6e486fe75bd4ea.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=drew@pdp7.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).