* [PATCH] iio: adc: ad7124: fix mask used for setting AIN_BUFP & AIN_BUFM bits
@ 2022-01-12 20:00 Cosmin Tanislav
2022-01-15 18:56 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Cosmin Tanislav @ 2022-01-12 20:00 UTC (permalink / raw)
Cc: cosmin.tanislav, demonsingur, Lars-Peter Clausen,
Michael Hennerich, Jonathan Cameron, linux-iio, linux-kernel
According to page 90 of the datasheet [1], AIN_BUFP is bit 6 and
AIN_BUFM is bit 5 of the CONFIG_0 -> CONFIG_7 registers.
Fix the mask used for setting these bits.
[1]: https://www.analog.com/media/en/technical-documentation/data-sheets/ad7124-8.pdf
Fixes: 0eaecea6e487 ("iio: adc: ad7124: Add buffered input support")
Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
---
drivers/iio/adc/ad7124.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
index e45c600fccc0..18c154afbd7a 100644
--- a/drivers/iio/adc/ad7124.c
+++ b/drivers/iio/adc/ad7124.c
@@ -76,7 +76,7 @@
#define AD7124_CONFIG_REF_SEL(x) FIELD_PREP(AD7124_CONFIG_REF_SEL_MSK, x)
#define AD7124_CONFIG_PGA_MSK GENMASK(2, 0)
#define AD7124_CONFIG_PGA(x) FIELD_PREP(AD7124_CONFIG_PGA_MSK, x)
-#define AD7124_CONFIG_IN_BUFF_MSK GENMASK(7, 6)
+#define AD7124_CONFIG_IN_BUFF_MSK GENMASK(6, 5)
#define AD7124_CONFIG_IN_BUFF(x) FIELD_PREP(AD7124_CONFIG_IN_BUFF_MSK, x)
/* AD7124_FILTER_X */
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iio: adc: ad7124: fix mask used for setting AIN_BUFP & AIN_BUFM bits
2022-01-12 20:00 [PATCH] iio: adc: ad7124: fix mask used for setting AIN_BUFP & AIN_BUFM bits Cosmin Tanislav
@ 2022-01-15 18:56 ` Jonathan Cameron
2022-01-15 18:54 ` Cosmin Tanislav
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2022-01-15 18:56 UTC (permalink / raw)
To: Cosmin Tanislav
Cc: cosmin.tanislav, Lars-Peter Clausen, Michael Hennerich, linux-iio,
linux-kernel
On Wed, 12 Jan 2022 22:00:36 +0200
Cosmin Tanislav <demonsingur@gmail.com> wrote:
> According to page 90 of the datasheet [1], AIN_BUFP is bit 6 and
> AIN_BUFM is bit 5 of the CONFIG_0 -> CONFIG_7 registers.
>
> Fix the mask used for setting these bits.
>
> [1]: https://www.analog.com/media/en/technical-documentation/data-sheets/ad7124-8.pdf
>
> Fixes: 0eaecea6e487 ("iio: adc: ad7124: Add buffered input support")
> Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
Curious that didn't cause problems anyone noticed before. Ah well.
Applied to the fixes-togreg branch of iio.git and marked for stable.
Note that branch will probably be rebased after rc1 as I have some
other things that need rc1 which will be in same pull request.
Jonathan
> ---
> drivers/iio/adc/ad7124.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
> index e45c600fccc0..18c154afbd7a 100644
> --- a/drivers/iio/adc/ad7124.c
> +++ b/drivers/iio/adc/ad7124.c
> @@ -76,7 +76,7 @@
> #define AD7124_CONFIG_REF_SEL(x) FIELD_PREP(AD7124_CONFIG_REF_SEL_MSK, x)
> #define AD7124_CONFIG_PGA_MSK GENMASK(2, 0)
> #define AD7124_CONFIG_PGA(x) FIELD_PREP(AD7124_CONFIG_PGA_MSK, x)
> -#define AD7124_CONFIG_IN_BUFF_MSK GENMASK(7, 6)
> +#define AD7124_CONFIG_IN_BUFF_MSK GENMASK(6, 5)
> #define AD7124_CONFIG_IN_BUFF(x) FIELD_PREP(AD7124_CONFIG_IN_BUFF_MSK, x)
>
> /* AD7124_FILTER_X */
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iio: adc: ad7124: fix mask used for setting AIN_BUFP & AIN_BUFM bits
2022-01-15 18:56 ` Jonathan Cameron
@ 2022-01-15 18:54 ` Cosmin Tanislav
0 siblings, 0 replies; 3+ messages in thread
From: Cosmin Tanislav @ 2022-01-15 18:54 UTC (permalink / raw)
To: Jonathan Cameron
Cc: cosmin.tanislav, Lars-Peter Clausen, Michael Hennerich, linux-iio,
linux-kernel
On 1/15/22 20:56, Jonathan Cameron wrote:
> On Wed, 12 Jan 2022 22:00:36 +0200
> Cosmin Tanislav <demonsingur@gmail.com> wrote:
>
>> According to page 90 of the datasheet [1], AIN_BUFP is bit 6 and
>> AIN_BUFM is bit 5 of the CONFIG_0 -> CONFIG_7 registers.
>>
>> Fix the mask used for setting these bits.
>>
>> [1]: https://www.analog.com/media/en/technical-documentation/data-sheets/ad7124-8.pdf
>>
>> Fixes: 0eaecea6e487 ("iio: adc: ad7124: Add buffered input support")
>> Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
> Curious that didn't cause problems anyone noticed before. Ah well.
>
I only noticed it because I'm writing a driver for a similar device,
it was not even reported by anyone.
> Applied to the fixes-togreg branch of iio.git and marked for stable.
>
> Note that branch will probably be rebased after rc1 as I have some
> other things that need rc1 which will be in same pull request.
>
> Jonathan
>
>> ---
>> drivers/iio/adc/ad7124.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
>> index e45c600fccc0..18c154afbd7a 100644
>> --- a/drivers/iio/adc/ad7124.c
>> +++ b/drivers/iio/adc/ad7124.c
>> @@ -76,7 +76,7 @@
>> #define AD7124_CONFIG_REF_SEL(x) FIELD_PREP(AD7124_CONFIG_REF_SEL_MSK, x)
>> #define AD7124_CONFIG_PGA_MSK GENMASK(2, 0)
>> #define AD7124_CONFIG_PGA(x) FIELD_PREP(AD7124_CONFIG_PGA_MSK, x)
>> -#define AD7124_CONFIG_IN_BUFF_MSK GENMASK(7, 6)
>> +#define AD7124_CONFIG_IN_BUFF_MSK GENMASK(6, 5)
>> #define AD7124_CONFIG_IN_BUFF(x) FIELD_PREP(AD7124_CONFIG_IN_BUFF_MSK, x)
>>
>> /* AD7124_FILTER_X */
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-15 18:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-12 20:00 [PATCH] iio: adc: ad7124: fix mask used for setting AIN_BUFP & AIN_BUFM bits Cosmin Tanislav
2022-01-15 18:56 ` Jonathan Cameron
2022-01-15 18:54 ` Cosmin Tanislav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).