From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Shreeya Patel <shreeya.patel@collabora.com>,
jic23@kernel.org, lars@metafoo.de
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
krisman@collabora.com, kernel@collabora.com,
alvaro.soliverez@collabora.com
Subject: Re: [PATCH] iio: light: Add raw attribute
Date: Thu, 11 Aug 2022 13:43:09 +0300 [thread overview]
Message-ID: <e8b99943-d930-2d92-67ba-62ae17f7cd56@collabora.com> (raw)
In-Reply-To: <20220811101443.499761-1-shreeya.patel@collabora.com>
On 8/11/22 13:14, Shreeya Patel wrote:
> + case IIO_CHAN_INFO_RAW:
> + ret = ltrf216a_set_power_state(data, true);
> + if (ret)
> + return ret;
> + mutex_lock(&data->lock);
> + ret = ltrf216a_read_data(data, LTRF216A_ALS_DATA_0);
> + mutex_unlock(&data->lock);
ltrf216a_set_power_state(data, false) should be called before return.
> + if (ret < 0)
> + return ret;
> + *val = ret;
> + ltrf216a_set_power_state(data, false);
--
Best regards,
Dmitry
next prev parent reply other threads:[~2022-08-11 10:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 10:14 [PATCH] iio: light: Add raw attribute Shreeya Patel
2022-08-11 10:43 ` Dmitry Osipenko [this message]
2022-08-11 10:51 ` Shreeya Patel
2022-08-11 13:25 ` Jonathan Cameron
2022-08-11 14:18 ` Shreeya Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8b99943-d930-2d92-67ba-62ae17f7cd56@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=alvaro.soliverez@collabora.com \
--cc=jic23@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox