From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99E7450285 for ; Wed, 1 May 2024 09:45:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714556707; cv=none; b=d2zlk0oaxf7/GG9V8HpEXY7P0v7XlBye/UEpALgdqvlAxo+/ocWgEp3g5567W0h3SYNBnILrt1dQeSjKSoe5ZF7g8PAzwzOvS0jupbPZT2q8Md/gXiBAGDoPjpW41kOmu3W5kYqETg/rFTbxA3LBMdHdpmpnRHvMTYYVuQYyOuE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714556707; c=relaxed/simple; bh=pry+PQ7L3VsSddwQ20gj4XnNTiFrnFQyGjhMreF2cys=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KhFLWMmlSi9vmrET2sSoo5cFudIfpOGmx21D96m1IDfs2unVZ4d5LZhNAd5KmhLDIbzF7jbDfU270/5PJOuo4nHaIq//LpypK+F+4Tj/nwBoxHV1mv3bdy8AQdnyxeiPCyiLA6LnrXEYFfder7aY/mzYPxbj1/+LK19JPCMPRS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uqQRXpAN; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uqQRXpAN" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2db6f5977e1so78001831fa.2 for ; Wed, 01 May 2024 02:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714556704; x=1715161504; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=xnObvPwiieYwnQInszTH7mfu0PtHsqWytCTqPKrebKU=; b=uqQRXpANmzC0ZUuxn6qeNzy6qpUNCUlh4MYpqBO/USeL4ehKaYxGwl3JCs3iMIrrsS XqLfMgDyZ1Hh1XZWn91xi0/GgTaq9GpIn2Ql1gu/sihbn5f7eCFYZjX06FpzQwbwo2ms /Hhcgb1Rz3cBN1Ll1zWoXBDIjTStrBVg5mGHFo5iPK+it8jJBZgKNceeyjrIpF/PjJNp 6wXJG3fsNz+qI+4HKLJDzoeZsY+dmQw49Ak7dsrWD5dQpJPz3sIPWUQubIqNkAM/yrqn xgZUDjeOcOQ1Q7yPaBXGguql0tCSTvq1kNuVzb6P3UFZxhA7iR2sz+0BwAiiYBJFycSl BMGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714556704; x=1715161504; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xnObvPwiieYwnQInszTH7mfu0PtHsqWytCTqPKrebKU=; b=Z7Xye1U2IX7bIBID2o0Nux/MZyWNWCwn6sIdgAkT0tDhvIEnG4s1OvNTLiFa6pSbE+ 1x8EMLgOrY7CtIsjF30RIMGcYRUIxxPUFrITTcGyR/mbRcu6ofLnc5sCoahhaRMT4YXk 2C+8Zm5M3nYEK9ZPijxOBDr5lZrJO4IaMM5rjAGv8zOlHlu/pk688bb2V466w/PJpxqC 8KWd80pxLT9EWJLzVAuDXilXniRkaTjJRWzfcual2I1DmFYQrT4fHeY9gFb6HhvVQK/o VNGYXhhHTCdA8Qp/JTmnhd8Nohq7Co7qdq5UUCX4zfRT+YZW7D5AGqUJr3PzzGnp2mKA lyqQ== X-Forwarded-Encrypted: i=1; AJvYcCVD99RmrfvuMWCuTo5mcPAgPfznCu59R4aHc+NgDcrmBYuZUU9IeSq3ohRzQJSh+pc+I+3f7YFiCwc49WloT83cRFevLUw7CX4D X-Gm-Message-State: AOJu0YzE1XFE+0xV842kBaiZXecjL2/a/oTAV8UdP4gytMAi68otBQGQ 0bvoFai1iCe6LntEG0wLGm1zITgDAmnw26s/Iz6H24/XjZi+gVW81ONKMNbR1A+pM9UlNTycsHp +3ss= X-Google-Smtp-Source: AGHT+IEiHGFsYiETxtdbiTTE6FVJmSJEATiezAy2M+TLp1Kda1XmZdBwe5r9aL4qvSyu9yN0MHLvSQ== X-Received: by 2002:a2e:2286:0:b0:2da:aa0:f948 with SMTP id i128-20020a2e2286000000b002da0aa0f948mr1402233lji.8.1714556703906; Wed, 01 May 2024 02:45:03 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id f12-20020a2eb38c000000b002e0f0372923sm443596lje.116.2024.05.01.02.45.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 May 2024 02:45:03 -0700 (PDT) Message-ID: Date: Wed, 1 May 2024 11:45:00 +0200 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/3] Add support for Sensirion SDP500 To: Petar Stoykov , linux-iio@vger.kernel.org Cc: Jonathan Cameron , Krzysztof Kozlowski , Lars-Peter Clausen , Rob Herring , Andy Shevchenko , Angel Iglesias , Conor Dooley , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30/04/2024 17:27, Petar Stoykov wrote: > functions in use so it should be fine here too. > > All feedback is appreciated! Thank you for taking the time to review this. > > v1->v2: > Many fixes suggested by Jonathan Cameron and Krzysztof Kozlowsk. No, be specific. What EXACTLY changed. This is way too generic. Considering entire indentation is broken, I could assume you actually did not implement feedback. Best regards, Krzysztof