linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Scott Matheina <scott@matheina.com>, linux-kernel@vger.kernel.org
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	linux-iio@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCHv4 4/8] Fix braces not present on all arms of if else statement
Date: Fri, 30 Dec 2016 18:48:40 +0000	[thread overview]
Message-ID: <ec39ba5e-f797-575f-660f-b3ef9b6234e5@kernel.org> (raw)
In-Reply-To: <9e9dafdc-1687-9392-5087-a2b846804b7d@kernel.org>

On 30/12/16 18:46, Jonathan Cameron wrote:
> On 25/12/16 19:56, Scott Matheina wrote:
>> Adds braces to second arm of if else statement.
>>
>> Signed-off-by: Scott Matheina <scott@matheina.com>
> This patch is actually correct so applied to the togreg branch of iio.git.
Ah, patch title could be better. Should mention which driver it is for as
it is common for people to cherrypick individual patches out of a series
(like I just did).

I'll fix this one up to
staging:iio:adt7316...

Jonathan
> 
> Thanks,
> 
> Jonathan
>> ---
>>  drivers/staging/iio/addac/adt7316.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
>> index 2b584a0..e78d302 100644
>> --- a/drivers/staging/iio/addac/adt7316.c
>> +++ b/drivers/staging/iio/addac/adt7316.c
>> @@ -661,8 +661,9 @@ static ssize_t adt7316_store_da_high_resolution(struct device *dev,
>>  			chip->dac_bits = 12;
>>  		else if (chip->id == ID_ADT7317 || chip->id == ID_ADT7517)
>>  			chip->dac_bits = 10;
>> -	} else
>> +	} else {
>>  		config3 = chip->config3 & (~ADT7316_DA_HIGH_RESOLUTION);
>> +	}
>>  
>>  	ret = chip->bus.write(chip->bus.client, ADT7316_CONFIG3, config3);
>>  	if (ret)
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


  reply	other threads:[~2016-12-30 18:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-25 19:56 [PATCHv4 0/8] Checkpatch fixes to driver/staging/iio/addac Scott Matheina
2016-12-25 19:56 ` [PATCHv4 1/8] fixed long description text exceeding 80 characters Scott Matheina
2016-12-30 18:40   ` Jonathan Cameron
2016-12-25 19:56 ` [PATCHv4 2/8] Fixed variables not being consistently lower case Scott Matheina
2016-12-25 20:31   ` kbuild test robot
2016-12-25 19:56 ` [PATCHv4 3/8] Fix camel case issues Scott Matheina
2016-12-25 20:54   ` kbuild test robot
2016-12-30 18:45   ` Jonathan Cameron
2016-12-25 19:56 ` [PATCHv4 4/8] Fix braces not present on all arms of if else statement Scott Matheina
2016-12-30 18:46   ` Jonathan Cameron
2016-12-30 18:48     ` Jonathan Cameron [this message]
2016-12-31  2:40       ` Scott Matheina
     [not found]     ` <59e63be5-c105-e8fc-91d0-96009d748d34@matheina.com>
2016-12-31  0:49       ` Scott Matheina
2016-12-25 19:56 ` [PATCHv4 6/8] Fixed code wrap alignment with preceding ( Scott Matheina
2016-12-30 18:51   ` Jonathan Cameron
2016-12-25 19:56 ` [PATCHv4 7/8] Changed code to align with coding style of using octat Scott Matheina
2016-12-25 20:41   ` kbuild test robot
2016-12-30 18:53   ` Jonathan Cameron
2016-12-25 19:56 ` [PATCHv4 8/8] Fixes style issues due to mis-aligned carry over lines Scott Matheina
2016-12-25 21:18   ` kbuild test robot
2016-12-30 18:56   ` Jonathan Cameron
  -- strict thread matches above, loose matches on Subject: below --
2016-12-25 19:41 [PATCHv4 0/8] Checkpatch fixes to driver/staging/iio/addac Scott Matheina
2016-12-25 19:41 ` [PATCHv4 4/8] Fix braces not present on all arms of if else statement Scott Matheina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec39ba5e-f797-575f-660f-b3ef9b6234e5@kernel.org \
    --to=jic23@kernel.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=knaack.h@gmx.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=scott@matheina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).