From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <mranostay@gmail.com>,
Colin King <colin.king@canonical.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Sanchayan Maity <maitysanchayan@gmail.com>,
Gregor Boirie <gregor.boirie@parrot.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: chemical: atlas-ph-sensor: fix typo in val assignment
Date: Sun, 21 Aug 2016 16:12:14 +0100 [thread overview]
Message-ID: <ed277014-36e8-fc78-a7fb-1b52e258ef78@kernel.org> (raw)
In-Reply-To: <CAKzfze97P6yJEMAeg6Wv5UMDV4iuqBSQOdeLjG1Ctf_xywQxSg@mail.gmail.com>
On 27/07/16 10:28, Matt Ranostay wrote:
> On Mon, Jul 25, 2016 at 3:06 PM, Colin King <colin.king@canonical.com> wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Fix an incorrect assignment due to a typo on a variable name. The
>> variable val2 should be assigned 100000 and not val.
>
> Yikes! Good catch..
>
> Reviewed-By: Matt Ranostay <mranostay@gmail.com>
>
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks Colin.
Applied to the fixes-togreg branch of iio.git. Should head upstream
in a day or two.
Jonathan
>> ---
>> drivers/iio/chemical/atlas-ph-sensor.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-ph-sensor.c
>> index ae038a5..407f141 100644
>> --- a/drivers/iio/chemical/atlas-ph-sensor.c
>> +++ b/drivers/iio/chemical/atlas-ph-sensor.c
>> @@ -434,7 +434,7 @@ static int atlas_read_raw(struct iio_dev *indio_dev,
>> break;
>> case IIO_ELECTRICALCONDUCTIVITY:
>> *val = 1; /* 0.00001 */
>> - *val = 100000;
>> + *val2 = 100000;
>> break;
>> case IIO_CONCENTRATION:
>> *val = 0; /* 0.000000001 */
>> --
>> 2.8.1
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2016-08-21 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 22:06 [PATCH] iio: chemical: atlas-ph-sensor: fix typo in val assignment Colin King
2016-07-27 9:28 ` Matt Ranostay
2016-08-21 15:12 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed277014-36e8-fc78-a7fb-1b52e258ef78@kernel.org \
--to=jic23@kernel.org \
--cc=colin.king@canonical.com \
--cc=gregor.boirie@parrot.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maitysanchayan@gmail.com \
--cc=mranostay@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).