* [PATCH] iio: chemical: atlas-ph-sensor: fix typo in val assignment
@ 2016-07-25 22:06 Colin King
2016-07-27 9:28 ` Matt Ranostay
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2016-07-25 22:06 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Matt Ranostay, Sanchayan Maity,
Gregor Boirie, linux-iio
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Fix an incorrect assignment due to a typo on a variable name. The
variable val2 should be assigned 100000 and not val.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/iio/chemical/atlas-ph-sensor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-ph-sensor.c
index ae038a5..407f141 100644
--- a/drivers/iio/chemical/atlas-ph-sensor.c
+++ b/drivers/iio/chemical/atlas-ph-sensor.c
@@ -434,7 +434,7 @@ static int atlas_read_raw(struct iio_dev *indio_dev,
break;
case IIO_ELECTRICALCONDUCTIVITY:
*val = 1; /* 0.00001 */
- *val = 100000;
+ *val2 = 100000;
break;
case IIO_CONCENTRATION:
*val = 0; /* 0.000000001 */
--
2.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: chemical: atlas-ph-sensor: fix typo in val assignment
2016-07-25 22:06 [PATCH] iio: chemical: atlas-ph-sensor: fix typo in val assignment Colin King
@ 2016-07-27 9:28 ` Matt Ranostay
2016-08-21 15:12 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Matt Ranostay @ 2016-07-27 9:28 UTC (permalink / raw)
To: Colin King
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Sanchayan Maity, Gregor Boirie,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
On Mon, Jul 25, 2016 at 3:06 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Fix an incorrect assignment due to a typo on a variable name. The
> variable val2 should be assigned 100000 and not val.
Yikes! Good catch..
Reviewed-By: Matt Ranostay <mranostay@gmail.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/iio/chemical/atlas-ph-sensor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-ph-sensor.c
> index ae038a5..407f141 100644
> --- a/drivers/iio/chemical/atlas-ph-sensor.c
> +++ b/drivers/iio/chemical/atlas-ph-sensor.c
> @@ -434,7 +434,7 @@ static int atlas_read_raw(struct iio_dev *indio_dev,
> break;
> case IIO_ELECTRICALCONDUCTIVITY:
> *val = 1; /* 0.00001 */
> - *val = 100000;
> + *val2 = 100000;
> break;
> case IIO_CONCENTRATION:
> *val = 0; /* 0.000000001 */
> --
> 2.8.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: chemical: atlas-ph-sensor: fix typo in val assignment
2016-07-27 9:28 ` Matt Ranostay
@ 2016-08-21 15:12 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2016-08-21 15:12 UTC (permalink / raw)
To: Matt Ranostay, Colin King
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Sanchayan Maity, Gregor Boirie, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
On 27/07/16 10:28, Matt Ranostay wrote:
> On Mon, Jul 25, 2016 at 3:06 PM, Colin King <colin.king@canonical.com> wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Fix an incorrect assignment due to a typo on a variable name. The
>> variable val2 should be assigned 100000 and not val.
>
> Yikes! Good catch..
>
> Reviewed-By: Matt Ranostay <mranostay@gmail.com>
>
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks Colin.
Applied to the fixes-togreg branch of iio.git. Should head upstream
in a day or two.
Jonathan
>> ---
>> drivers/iio/chemical/atlas-ph-sensor.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-ph-sensor.c
>> index ae038a5..407f141 100644
>> --- a/drivers/iio/chemical/atlas-ph-sensor.c
>> +++ b/drivers/iio/chemical/atlas-ph-sensor.c
>> @@ -434,7 +434,7 @@ static int atlas_read_raw(struct iio_dev *indio_dev,
>> break;
>> case IIO_ELECTRICALCONDUCTIVITY:
>> *val = 1; /* 0.00001 */
>> - *val = 100000;
>> + *val2 = 100000;
>> break;
>> case IIO_CONCENTRATION:
>> *val = 0; /* 0.000000001 */
>> --
>> 2.8.1
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-21 15:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-25 22:06 [PATCH] iio: chemical: atlas-ph-sensor: fix typo in val assignment Colin King
2016-07-27 9:28 ` Matt Ranostay
2016-08-21 15:12 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).