* [PATCH] iio: dac: ad5446: Add AD5542 to the spi id table
@ 2025-10-14 16:11 Nuno Sá via B4 Relay
2025-10-14 17:15 ` David Lechner
0 siblings, 1 reply; 4+ messages in thread
From: Nuno Sá via B4 Relay @ 2025-10-14 16:11 UTC (permalink / raw)
To: linux-iio
Cc: Michael Hennerich, Jonathan Cameron, David Lechner,
Andy Shevchenko
From: Michael Hennerich <michael.hennerich@analog.com>
This adds support for the AD5542 single channel Current Source and
Voltage Output DACs.
It is similar to the AD5542A model so just use the same id.
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
---
drivers/iio/dac/ad5446.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
index ad304b0fec08..6e4103f4afcb 100644
--- a/drivers/iio/dac/ad5446.c
+++ b/drivers/iio/dac/ad5446.c
@@ -422,6 +422,7 @@ static const struct spi_device_id ad5446_spi_ids[] = {
{"ad5512a", ID_AD5512A},
{"ad5541a", ID_AD5541A},
{"ad5542a", ID_AD5541A}, /* ad5541a and ad5542a are compatible */
+ {"ad5542", ID_AD5541A}, /* ad5541a and ad5542a are compatible */
{"ad5543", ID_AD5541A}, /* ad5541a and ad5543 are compatible */
{"ad5553", ID_AD5553},
{"ad5600", ID_AD5600},
---
base-commit: 4b17a60d1e1c2d9d2ccbd58642f6f4ac2fa364ba
change-id: 20251014-dev-add-ad5542-8c8934de80ee
--
Thanks!
- Nuno Sá
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: dac: ad5446: Add AD5542 to the spi id table
2025-10-14 16:11 [PATCH] iio: dac: ad5446: Add AD5542 to the spi id table Nuno Sá via B4 Relay
@ 2025-10-14 17:15 ` David Lechner
2025-10-15 8:08 ` Nuno Sá
0 siblings, 1 reply; 4+ messages in thread
From: David Lechner @ 2025-10-14 17:15 UTC (permalink / raw)
To: nuno.sa, linux-iio; +Cc: Michael Hennerich, Jonathan Cameron, Andy Shevchenko
On 10/14/25 11:11 AM, Nuno Sá via B4 Relay wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> This adds support for the AD5542 single channel Current Source and
> Voltage Output DACs.
>
> It is similar to the AD5542A model so just use the same id.
>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> ---
> drivers/iio/dac/ad5446.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
> index ad304b0fec08..6e4103f4afcb 100644
> --- a/drivers/iio/dac/ad5446.c
> +++ b/drivers/iio/dac/ad5446.c
> @@ -422,6 +422,7 @@ static const struct spi_device_id ad5446_spi_ids[] = {
> {"ad5512a", ID_AD5512A},
> {"ad5541a", ID_AD5541A},
> {"ad5542a", ID_AD5541A}, /* ad5541a and ad5542a are compatible */
> + {"ad5542", ID_AD5541A}, /* ad5541a and ad5542a are compatible */
Should the comment say ad5542 instead of ad5542a?
> {"ad5543", ID_AD5541A}, /* ad5541a and ad5543 are compatible */
> {"ad5553", ID_AD5553},
> {"ad5600", ID_AD5600},
>
> ---
> base-commit: 4b17a60d1e1c2d9d2ccbd58642f6f4ac2fa364ba
> change-id: 20251014-dev-add-ad5542-8c8934de80ee
> --
>
> Thanks!
> - Nuno Sá
>
>
Interesting... no devicetree bindings for these chips?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: dac: ad5446: Add AD5542 to the spi id table
2025-10-14 17:15 ` David Lechner
@ 2025-10-15 8:08 ` Nuno Sá
2025-10-18 16:34 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Nuno Sá @ 2025-10-15 8:08 UTC (permalink / raw)
To: David Lechner, nuno.sa, linux-iio
Cc: Michael Hennerich, Jonathan Cameron, Andy Shevchenko
On Tue, 2025-10-14 at 12:15 -0500, David Lechner wrote:
> On 10/14/25 11:11 AM, Nuno Sá via B4 Relay wrote:
> > From: Michael Hennerich <michael.hennerich@analog.com>
> >
> > This adds support for the AD5542 single channel Current Source and
> > Voltage Output DACs.
> >
> > It is similar to the AD5542A model so just use the same id.
> >
> > Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > ---
> > drivers/iio/dac/ad5446.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
> > index ad304b0fec08..6e4103f4afcb 100644
> > --- a/drivers/iio/dac/ad5446.c
> > +++ b/drivers/iio/dac/ad5446.c
> > @@ -422,6 +422,7 @@ static const struct spi_device_id ad5446_spi_ids[] = {
> > {"ad5512a", ID_AD5512A},
> > {"ad5541a", ID_AD5541A},
> > {"ad5542a", ID_AD5541A}, /* ad5541a and ad5542a are compatible */
> > + {"ad5542", ID_AD5541A}, /* ad5541a and ad5542a are compatible */
>
> Should the comment say ad5542 instead of ad5542a?
Yes.
>
> > {"ad5543", ID_AD5541A}, /* ad5541a and ad5543 are compatible */
> > {"ad5553", ID_AD5553},
> > {"ad5600", ID_AD5600},
> >
> > ---
> > base-commit: 4b17a60d1e1c2d9d2ccbd58642f6f4ac2fa364ba
> > change-id: 20251014-dev-add-ad5542-8c8934de80ee
> > --
> >
> > Thanks!
> > - Nuno Sá
> >
> >
>
> Interesting... no devicetree bindings for these chips?
This driver is old enough where things were less strict (I guess) and it seems
no one added bindings for this.
- Nuno Sá
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: dac: ad5446: Add AD5542 to the spi id table
2025-10-15 8:08 ` Nuno Sá
@ 2025-10-18 16:34 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2025-10-18 16:34 UTC (permalink / raw)
To: Nuno Sá
Cc: David Lechner, nuno.sa, linux-iio, Michael Hennerich,
Andy Shevchenko
On Wed, 15 Oct 2025 09:08:36 +0100
Nuno Sá <noname.nuno@gmail.com> wrote:
> On Tue, 2025-10-14 at 12:15 -0500, David Lechner wrote:
> > On 10/14/25 11:11 AM, Nuno Sá via B4 Relay wrote:
> > > From: Michael Hennerich <michael.hennerich@analog.com>
> > >
> > > This adds support for the AD5542 single channel Current Source and
> > > Voltage Output DACs.
> > >
> > > It is similar to the AD5542A model so just use the same id.
> > >
> > > Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> > > Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> > > ---
> > > drivers/iio/dac/ad5446.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
> > > index ad304b0fec08..6e4103f4afcb 100644
> > > --- a/drivers/iio/dac/ad5446.c
> > > +++ b/drivers/iio/dac/ad5446.c
> > > @@ -422,6 +422,7 @@ static const struct spi_device_id ad5446_spi_ids[] = {
> > > {"ad5512a", ID_AD5512A},
> > > {"ad5541a", ID_AD5541A},
> > > {"ad5542a", ID_AD5541A}, /* ad5541a and ad5542a are compatible */
> > > + {"ad5542", ID_AD5541A}, /* ad5541a and ad5542a are compatible */
> >
> > Should the comment say ad5542 instead of ad5542a?
>
> Yes.
>
> >
> > > {"ad5543", ID_AD5541A}, /* ad5541a and ad5543 are compatible */
> > > {"ad5553", ID_AD5553},
> > > {"ad5600", ID_AD5600},
> > >
> > > ---
> > > base-commit: 4b17a60d1e1c2d9d2ccbd58642f6f4ac2fa364ba
> > > change-id: 20251014-dev-add-ad5542-8c8934de80ee
> > > --
> > >
> > > Thanks!
> > > - Nuno Sá
> > >
> > >
> >
> > Interesting... no devicetree bindings for these chips?
>
> This driver is old enough where things were less strict (I guess) and it seems
> no one added bindings for this.
Dates back to board file days I think. Relying on the stuff that was added
to bridge that gap by matching stripped part number from compatible against the
i2c_device_id.
If you fancy tidying that up and adding both of_device_id table and a binding
doc that would be great.
Thanks,
J
>
> - Nuno Sá
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-18 16:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-14 16:11 [PATCH] iio: dac: ad5446: Add AD5542 to the spi id table Nuno Sá via B4 Relay
2025-10-14 17:15 ` David Lechner
2025-10-15 8:08 ` Nuno Sá
2025-10-18 16:34 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).