* [PATCH] staging: iio: replace symbolic permission
[not found] <CGME20161130152410epcms5p156ead39cb7b0dd842448360a87fbc0e7@epcms5p1>
@ 2016-11-30 15:24 ` Amit Kumar Kushwaha
2016-12-03 10:26 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Amit Kumar Kushwaha @ 2016-11-30 15:24 UTC (permalink / raw)
To: jic23@kernel.org
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
This patch fixes the following checkpatch.pl warning in ad7150.c
WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred
Occured during build.
Signed-off-by: Amit Kushwaha <kushwaha.a@samsung.com>
---
drivers/staging/iio/cdc/ad7150.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c
index 5578a07..9ab00c0 100644
--- a/drivers/staging/iio/cdc/ad7150.c
+++ b/drivers/staging/iio/cdc/ad7150.c
@@ -414,7 +414,7 @@ static ssize_t ad7150_store_timeout(struct device *dev,
#define AD7150_TIMEOUT(chan, type, dir, ev_type, ev_dir) \
IIO_DEVICE_ATTR(in_capacitance##chan##_##type##_##dir##_timeout, \
- S_IRUGO | S_IWUSR, \
+ 0644, \
&ad7150_show_timeout, \
&ad7150_store_timeout, \
IIO_UNMOD_EVENT_CODE(IIO_CAPACITANCE, \
--
2.10.2.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: iio: replace symbolic permission
2016-11-30 15:24 ` [PATCH] staging: iio: replace symbolic permission Amit Kumar Kushwaha
@ 2016-12-03 10:26 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2016-12-03 10:26 UTC (permalink / raw)
To: kushwaha.a
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org
On 30/11/16 15:24, Amit Kumar Kushwaha wrote:
> This patch fixes the following checkpatch.pl warning in ad7150.c
> WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred
> Occured during build.
>
> Signed-off-by: Amit Kushwaha <kushwaha.a@samsung.com>
I'm not overly fussed about these (and generally believe the churn isn't
worth the 'really minor' improvement in readability...)
Also for some reason it didn't apply. I've done it manually...
Anyhow, applied to the togreg branch of iio.git just so I don't get any
more emails about it...
Jonathan
> ---
> drivers/staging/iio/cdc/ad7150.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c
> index 5578a07..9ab00c0 100644
> --- a/drivers/staging/iio/cdc/ad7150.c
> +++ b/drivers/staging/iio/cdc/ad7150.c
> @@ -414,7 +414,7 @@ static ssize_t ad7150_store_timeout(struct device *dev,
>
> #define AD7150_TIMEOUT(chan, type, dir, ev_type, ev_dir) \
> IIO_DEVICE_ATTR(in_capacitance##chan##_##type##_##dir##_timeout, \
> - S_IRUGO | S_IWUSR, \
> + 0644, \
> &ad7150_show_timeout, \
> &ad7150_store_timeout, \
> IIO_UNMOD_EVENT_CODE(IIO_CAPACITANCE, \
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-03 14:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20161130152410epcms5p156ead39cb7b0dd842448360a87fbc0e7@epcms5p1>
2016-11-30 15:24 ` [PATCH] staging: iio: replace symbolic permission Amit Kumar Kushwaha
2016-12-03 10:26 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).